[Cluster-devel] [PATCH] rgmanager: Add IP "interface" parameter

[Fabio M. Di Nitto <fdinitto@redhat.com>]

Hi Ryan,

only one comment here.. many times we have been asked to implement
"interface" parameter to allow any random IP on any specific interface
(beside the pre configured ip on that interface).

Can we change the patch to simply fix both problems at once?
Effectively, the fact that 2 interfaces have 2 ip on the same subnet is
simply a corner case.

Maybe later on we can add something like: ifconfig iface up / down.

when doing ifconfig up we need to store the output of ip addresses
automatically assigned to that interface.

on shutdown, we need to check if the ip we are removing is the last one
on that interface _before_ issuing an ifconfig down in case there are
more ip resources associated to it.

The patch looks ok, but I would probably use a different term than
"interface" as it sounds very similar to the expected feature above.

Fabio

On 07/12/2012 07:23 PM, Ryan McCabe wrote:
> This patch adds an "interface" parameter for IP resources. The
> interface must already be configured and active. This parameter
> should be used only when at least two active interfaces have IP
> addresses on the same subnet and it's necessary to specify which
> particular interface should be used.
> 
> Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
> ---
>  rgmanager/src/resources/ip.sh |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/rgmanager/src/resources/ip.sh b/rgmanager/src/resources/ip.sh
> index 38d1ab9..3adbb12 100755
> --- a/rgmanager/src/resources/ip.sh
> +++ b/rgmanager/src/resources/ip.sh
> @@ -132,6 +132,15 @@ meta_data()
>  	    <content type="boolean"/>
>  	</parameter>
>  
> +	<parameter name="interface">
> +	    <longdesc lang="en">
> +	        The network interface to which the IP address should be added. The interface must already be configured and active. This parameter should be used only when at least two active interfaces have IP addresses on the same subnet and it is desired to have the IP address added to a particular interface.
> +	    </longdesc>
> +	    <shortdesc lang="en">
> +	        Network interface
> +	    </shortdesc>
> +	    <content type="string"/>
> +	</parameter>
>      </parameters>
>  
>      <actions>
> @@ -587,6 +596,10 @@ ipv6()
>  		fi
>  		
>  		if [ "$1" = "add" ]; then
> +			if [ -n "$OCF_RESKEY_interface" ] && \
> +			   [ "$OCF_RESKEY_interface" != $dev ]; then
> +				continue
> +			fi
>  			ipv6_same_subnet $ifaddr_exp/$maskbits $addr_exp
>  			if [ $? -ne 0 ]; then
>                                  continue
> @@ -670,6 +683,10 @@ ipv4()
>  		fi
>  
>  		if [ "$1" = "add" ]; then
> +			if [ -n "$OCF_RESKEY_interface" ] && \
> +			   [ "$OCF_RESKEY_interface" != $dev ]; then
> +				continue
> +			fi
>  		        ipv4_same_subnet $ifaddr/$maskbits $addr
>  			if [ $? -ne 0 ]; then
>  			        continue