From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Wed, 23 Nov 2011 11:15:58 +0100 Subject: [Cluster-devel] [PATCH 39/41] qdiskd: don't leak memory if we fail to read from disk In-Reply-To: <1322043360-17037-1-git-send-email-fdinitto@redhat.com> References: <1322043360-17037-1-git-send-email-fdinitto@redhat.com> Message-ID: <4c20f1a822d55cda2b22caea9f9d9cbd4a985a9c.1322043046.git.fdinitto@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Spotted by Coverity Scan Signed-off-by: Fabio M. Di Nitto --- :100644 100644 d0d05f0... 7c6e114... M cman/qdisk/disk.c cman/qdisk/disk.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/cman/qdisk/disk.c b/cman/qdisk/disk.c index d0d05f0..7c6e114 100644 --- a/cman/qdisk/disk.c +++ b/cman/qdisk/disk.c @@ -604,6 +604,7 @@ qdisk_read(target_info_t *disk, __off64_t offset, void *bufin, int count) rv = diskRawReadShadow(disk, offset, (char *)hdrp, disk->d_blksz); if (rv == -1) { + free(hdrp); return -1; } -- 1.7.4.4