cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node
Date: Fri, 13 Jul 2012 16:09:16 -0400	[thread overview]
Message-ID: <5000806C.8040605@redhat.com> (raw)
In-Reply-To: <20120711131435.GA73375@redhat.com>

On 07/11/2012 09:14 AM, Ryan McCabe wrote:
> Return RG_ERELO (Relocation failure; service running on original node) when
> relocation failed and the service was restarted successfully on the original
> node.
> 
> This is the behavior that's currently in the STABLE32 and RHEL6 branches.
> 
> Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
> ---
>  rgmanager/src/daemons/rg_state.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
> index 4357d21..9000f1b 100644
> --- a/rgmanager/src/daemons/rg_state.c
> +++ b/rgmanager/src/daemons/rg_state.c
> @@ -2061,7 +2061,7 @@ exhausted:
>  		       svcName);
>  		if (svc_start(svcName, RG_START_RECOVER) == 0) {
>  			*new_owner = me;
> -			return 0;
> +			return RG_ERELO;
>  		}
>  	}
>  
> 

Reviewed-by: Lon Hohberger <lhh@redhat.com>

-- Lon



      reply	other threads:[~2012-07-13 20:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 13:14 [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node Ryan McCabe
2012-07-13 20:09 ` Lon Hohberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5000806C.8040605@redhat.com \
    --to=lhh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).