cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node
@ 2012-07-11 13:14 Ryan McCabe
  2012-07-13 20:09 ` Lon Hohberger
  0 siblings, 1 reply; 2+ messages in thread
From: Ryan McCabe @ 2012-07-11 13:14 UTC (permalink / raw)
  To: cluster-devel.redhat.com

Return RG_ERELO (Relocation failure; service running on original node) when
relocation failed and the service was restarted successfully on the original
node.

This is the behavior that's currently in the STABLE32 and RHEL6 branches.

Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
---
 rgmanager/src/daemons/rg_state.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
index 4357d21..9000f1b 100644
--- a/rgmanager/src/daemons/rg_state.c
+++ b/rgmanager/src/daemons/rg_state.c
@@ -2061,7 +2061,7 @@ exhausted:
 		       svcName);
 		if (svc_start(svcName, RG_START_RECOVER) == 0) {
 			*new_owner = me;
-			return 0;
+			return RG_ERELO;
 		}
 	}
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node
  2012-07-11 13:14 [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node Ryan McCabe
@ 2012-07-13 20:09 ` Lon Hohberger
  0 siblings, 0 replies; 2+ messages in thread
From: Lon Hohberger @ 2012-07-13 20:09 UTC (permalink / raw)
  To: cluster-devel.redhat.com

On 07/11/2012 09:14 AM, Ryan McCabe wrote:
> Return RG_ERELO (Relocation failure; service running on original node) when
> relocation failed and the service was restarted successfully on the original
> node.
> 
> This is the behavior that's currently in the STABLE32 and RHEL6 branches.
> 
> Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
> ---
>  rgmanager/src/daemons/rg_state.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rgmanager/src/daemons/rg_state.c b/rgmanager/src/daemons/rg_state.c
> index 4357d21..9000f1b 100644
> --- a/rgmanager/src/daemons/rg_state.c
> +++ b/rgmanager/src/daemons/rg_state.c
> @@ -2061,7 +2061,7 @@ exhausted:
>  		       svcName);
>  		if (svc_start(svcName, RG_START_RECOVER) == 0) {
>  			*new_owner = me;
> -			return 0;
> +			return RG_ERELO;
>  		}
>  	}
>  
> 

Reviewed-by: Lon Hohberger <lhh@redhat.com>

-- Lon



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-13 20:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 13:14 [Cluster-devel] [PATCH] rgmanager: Fix return code when relocation fails and svc is running on original node Ryan McCabe
2012-07-13 20:09 ` Lon Hohberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).