From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster: RHEL6 - fsck.gfs2: Fix buffer overflow in get_lockproto_table
Date: Fri, 17 Aug 2012 06:02:33 +0200 [thread overview]
Message-ID: <502DC259.6090305@redhat.com> (raw)
In-Reply-To: <20120816210130.5EC643527@fedorahosted.org>
On 08/16/2012 11:01 PM, Andrew Price wrote:
> Gitweb: http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=f796ee8752712e9e523e1516bb9165b274552753
> Commit: f796ee8752712e9e523e1516bb9165b274552753
> Parent: 638deec0ccbf45862eee97294f09ba9d6b3f56d0
> Author: Andrew Price <anprice@redhat.com>
> AuthorDate: Sat Jul 7 22:03:24 2012 +0100
> Committer: Andrew Price <anprice@redhat.com>
> CommitterDate: Thu Aug 16 21:54:56 2012 +0100
>
> fsck.gfs2: Fix buffer overflow in get_lockproto_table
>
> Coverity discovered a buffer overflow in this function where an overly
> long cluster name in cluster.conf could cause a crash while repairing
> the superblock. This patch fixes the bug by making sure the lock table
> is composed sensibly, limiting the fsname to 16 chars as documented, and
> only allowing the cluster name (which doesn't seem to have a documented
> max size) to use the remaining space in the locktable name string.
cluster name is max 16 bytes too (including \0). It's actually verified
by cman at startup so it can't be longer than that.
Fabio
next parent reply other threads:[~2012-08-17 4:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120816210130.5EC643527@fedorahosted.org>
2012-08-17 4:02 ` Fabio M. Di Nitto [this message]
2012-08-17 9:57 ` [Cluster-devel] cluster: RHEL6 - fsck.gfs2: Fix buffer overflow in get_lockproto_table Andrew Price
2012-08-17 10:04 ` Fabio M. Di Nitto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502DC259.6090305@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).