From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio M. Di Nitto Date: Wed, 10 Oct 2012 10:11:32 +0200 Subject: [Cluster-devel] [PATCH 2/2] checkquorum.wdmd: add integration script with wdmd In-Reply-To: <24E144B8C0207547AD09C467A8259F75576A7EC3@lisa.maurer-it.com> References: <1349775365-31526-1-git-send-email-fdinitto@redhat.com> <1349775365-31526-2-git-send-email-fdinitto@redhat.com> <24E144B8C0207547AD09C467A8259F75576A7D44@lisa.maurer-it.com> <50751CEA.7050906@redhat.com> <24E144B8C0207547AD09C467A8259F75576A7EC3@lisa.maurer-it.com> Message-ID: <50752DB4.60502@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 10/10/2012 10:06 AM, Dietmar Maurer wrote: >> On 10/10/2012 6:26 AM, Dietmar Maurer wrote: >>>> +# rpm based distros >>>> +[ -d /etc/sysconfig ] && \ >>>> + [ -f /etc/sysconfig/checkquorum ] && \ >>>> + . /etc/sysconfig/checkquorum >>>> + >>>> +# deb based distros >>>> +[ ! -d /etc/sysconfig ] && \ >>>> + [ -f /etc/default/checkquorum ] && \ >>>> + . /etc/default/checkquorum >>>> + >>> >>> FYI: Some RAID tool vendors delivers utilities for debian which creates >> directory '/etc/sysconfig' >>> on debian boxes, so that test is not reliable. >>> >>> >> >> This might be a controversial argument. > > I just though there are better tests to see if you run on debian, for example: > > [ -f /etc/debian_version && -d /etc/default ] > that doesn?t scale well for debian derivates that don?t ship debian_version :) (see ubuntu & co..) You can?t even use something like "which dpkg" since the tool is available on rpm based distributions... or viceversa.. there is rpm for Debian & derivates. hardcoding all distributions is not optimal either, as they might change policy by version.... Fabio