cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Christine Caulfield <ccaulfie@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/3] libcman: fix possible string nontermination
Date: Thu, 11 Oct 2012 15:36:51 +0100	[thread overview]
Message-ID: <5076D983.5000208@redhat.com> (raw)
In-Reply-To: <1349965267-2261-1-git-send-email-jpokorny@redhat.com>

in RHEL6 those strings are copied using strcpy - I think it was changed 
in the STABLE branch to strncpy after a coverity scan

TBH the original strcpy is quite safe as the strings come from internal 
sources and are pre-validated.

Anyway, the arrays are allocated as size+1 so the strings will never 
overflow.

NACK.

On 11/10/12 15:21, Jan Pokorn? wrote:
> Hello once more,
>
> I discovered cases potentially leading to string overruns later
> in the processing.
>
> Jan Pokorn? (3):
>    libcman: fix possible string nontermination: node name
>    libcman: fix possible string nontermination: barrier name
>    libcman: fix possible string nontermination: barrier name
>
>   cman/lib/libcman.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>



      parent reply	other threads:[~2012-10-11 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 14:21 [Cluster-devel] [PATCH 0/3] libcman: fix possible string nontermination Jan Pokorný
2012-10-11 14:21 ` [Cluster-devel] [PATCH 1/3] libcman: fix possible string nontermination: node name Jan Pokorný
2012-10-11 14:21 ` [Cluster-devel] [PATCH 2/3] libcman: fix possible string nontermination: barrier name Jan Pokorný
2012-10-11 14:21 ` [Cluster-devel] [PATCH 3/3] " Jan Pokorný
2012-10-11 14:36 ` Christine Caulfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5076D983.5000208@redhat.com \
    --to=ccaulfie@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).