From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christine Caulfield Date: Thu, 11 Oct 2012 15:36:51 +0100 Subject: [Cluster-devel] [PATCH 0/3] libcman: fix possible string nontermination In-Reply-To: <1349965267-2261-1-git-send-email-jpokorny@redhat.com> References: <1349965267-2261-1-git-send-email-jpokorny@redhat.com> Message-ID: <5076D983.5000208@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit in RHEL6 those strings are copied using strcpy - I think it was changed in the STABLE branch to strncpy after a coverity scan TBH the original strcpy is quite safe as the strings come from internal sources and are pre-validated. Anyway, the arrays are allocated as size+1 so the strings will never overflow. NACK. On 11/10/12 15:21, Jan Pokorn? wrote: > Hello once more, > > I discovered cases potentially leading to string overruns later > in the processing. > > Jan Pokorn? (3): > libcman: fix possible string nontermination: node name > libcman: fix possible string nontermination: barrier name > libcman: fix possible string nontermination: barrier name > > cman/lib/libcman.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >