From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Fri, 16 Nov 2012 13:09:57 +0000 Subject: [Cluster-devel] [PATCH] mkfs.gfs2: Improve strings for translation In-Reply-To: <1353057944.2731.15.camel@menhir> References: <1353005859-14957-1-git-send-email-anprice@redhat.com> <1353057944.2731.15.camel@menhir> Message-ID: <50A63B25.1020606@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 16/11/12 09:25, Steven Whitehouse wrote: > Hi, > > I think that looks ok. One thought is whether it would be possible to > merge the argument parsing (and the help message) for the three-in-one > binary that we have at the moment. If we have arguments to set the mode > (so we can override the default provided by the binary name) then it > should be possible provided the options are not too different between > the three, It seems there are enough subtle differences (such as using different getopt features) between the three tools that making the option parsing code shared would be more trouble than it's worth. It should be fairly simple to merge each tool's option parsing and help printing code but I don't think it would buy us much so I'll leave it for now. Andy