From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2-utils: Fix build warnings in Fedora 18
Date: Mon, 17 Dec 2012 11:09:04 +0000 [thread overview]
Message-ID: <50CEFD50.7070205@redhat.com> (raw)
In-Reply-To: <1355524236-4829-1-git-send-email-kais58@sucs.org>
Hi Callum,
On 14/12/12 22:30, Callum Massey wrote:
> Dropped the * from gzFile *gzin_fd because gzFile is no longer defined
> as a void pointer.
>
> Rearranged incldes in libgfs2/lang.c so parser.h gets passed struct
> lgfs2_lang_state correctly.
>
> Signed-off-by: Callum Massey <kais58@sucs.org>
This is now in gfs2-utils.git master.
> ---
> gfs2/edit/savemeta.c | 2 +-
> gfs2/libgfs2/lang.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c
> index f35c35d..cfe18eb 100644
> --- a/gfs2/edit/savemeta.c
> +++ b/gfs2/edit/savemeta.c
> @@ -831,7 +831,7 @@ void savemeta(char *out_fn, int saveoption, int gziplevel)
> exit(0);
> }
>
> -static int restore_data(int fd, gzFile *gzin_fd, int printblocksonly,
> +static int restore_data(int fd, gzFile gzin_fd, int printblocksonly,
> int find_highblk)
Nice catch!
Thanks,
Andy
> {
> size_t rs;
> diff --git a/gfs2/libgfs2/lang.c b/gfs2/libgfs2/lang.c
> index ad9382f..40a4355 100644
> --- a/gfs2/libgfs2/lang.c
> +++ b/gfs2/libgfs2/lang.c
> @@ -7,8 +7,8 @@
> #include <limits.h>
> #include <ctype.h>
>
> -#include "parser.h"
> #include "lang.h"
> +#include "parser.h"
>
> const char* ast_type_string[] = {
> [AST_NONE] = "NONE",
>
prev parent reply other threads:[~2012-12-17 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 22:30 [Cluster-devel] [PATCH] gfs2-utils: Fix build warnings in Fedora 18 Callum Massey
2012-12-17 11:09 ` Andrew Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CEFD50.7070205@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).