From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Sat, 02 Feb 2013 18:15:12 -0800 Subject: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next() In-Reply-To: <20130202231135.GB3940@mtj.dyndns.org> References: <1359163872-1949-1-git-send-email-tj@kernel.org> <1359163872-1949-11-git-send-email-tj@kernel.org> <20130128155723.GC16789@redhat.com> <20130129151317.GA11609@redhat.com> <20130130212417.GJ24014@redhat.com> <20130131235320.GN6824@mtj.dyndns.org> <20130201001841.GP6824@mtj.dyndns.org> <20130201174443.GC3812@redhat.com> <20130201180028.GC31863@mtj.dyndns.org> <20130202231048.GA3940@mtj.dyndns.org> <20130202231135.GB3940@mtj.dyndns.org> Message-ID: <510DC830.70707@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 02/02/13 15:11, Tejun Heo wrote: > On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote: >> Fix it by ensuring proceeding to the next slot doesn't carry over the >> unaligned offset - ie. use round_up(id + 1, slot_distance) instead of >> id += slot_distance. >> >> Signed-off-by: Tejun Heo >> Reported-by: David Teigland >> Cc: KAMEZAWA Hiroyuki > > David, can you please test whether the patch makes the skipped > deletion bug go away? > > Thanks! Hugh, did you update the idr test suite or the radix-tree test suite? Is there an idr test suite or module? I have a kernel module source file named idr_test.c by Eric Paris. thanks, -- ~Randy