From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Price <anprice@redhat.com>
Date: Thu, 06 Jun 2013 14:53:42 +0100
Subject: [Cluster-devel] [PATCH 4/4] mkfs.gfs2: Add align option and
 update docs
In-Reply-To: <1604364747.48079746.1370524407342.JavaMail.root@redhat.com>
References: <1370520213-29676-1-git-send-email-anprice@redhat.com>
	<1370520213-29676-4-git-send-email-anprice@redhat.com>
	<1604364747.48079746.1370524407342.JavaMail.root@redhat.com>
Message-ID: <51B09466.3040003@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 06/06/13 14:13, Bob Peterson wrote:
> Hi,
>
> ----- Original Message -----
> | +	for (i = 0; options[i] != NULL; i+=2) {
>
> Just a nit here, but I'd recommend adding spaces, as per our standard: "i += 2"

Agreed - thanks.

Andy

>
> | +		printf("%15s  %-22s\n", options[i], options[i+1]);
>
> Same here: "i + 1"
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>