From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [gfs2-utils PATCH 1/7] fsck.gfs2: Fix reference to uninitialized variable
Date: Wed, 17 Jul 2013 07:30:26 +0200 [thread overview]
Message-ID: <51E62BF2.5070007@redhat.com> (raw)
In-Reply-To: <08b2ef646a21c19d0cdd1212fe8d4b4a8d7ee2b2.1373979296.git.rpeterso@redhat.com>
On 07/16/2013 02:56 PM, Bob Peterson wrote:
> This patch initializes a variable so that it no longer references
> it uninitialized.
>
> rhbz#984085
> ---
> gfs2/fsck/initialize.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gfs2/fsck/initialize.c b/gfs2/fsck/initialize.c
> index b01b240..936fd5e 100644
> --- a/gfs2/fsck/initialize.c
> +++ b/gfs2/fsck/initialize.c
> @@ -832,7 +832,7 @@ static int get_lockproto_table(struct gfs2_sbd *sdp)
> {
> FILE *fp;
> char line[PATH_MAX];
> - char *cluname, *end;
> + char *cluname, *end = NULL;
> const char *fsname, *cfgfile = "/etc/cluster/cluster.conf";
Just spotted this reference to cluster.conf ^^ remember it doesn't exist
anymore in the new era.
Fabio
next prev parent reply other threads:[~2013-07-17 5:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 12:56 [Cluster-devel] [gfs2-utils PATCH 1/7] fsck.gfs2: Fix reference to uninitialized variable Bob Peterson
2013-07-16 12:56 ` [Cluster-devel] [gfs2-utils PATCH 2/7] fsck.gfs2: fix some log messages Bob Peterson
2013-07-16 12:56 ` [Cluster-devel] [gfs2-utils PATCH 3/7] fsck.gfs2: Fix directory link on relocated directory dirents Bob Peterson
2013-07-16 12:56 ` [Cluster-devel] [gfs2-utils PATCH 4/7] fsck.gfs2: Fix infinite loop in pass1b caused by duplicates in hash table Bob Peterson
2013-07-16 12:56 ` [Cluster-devel] [gfs2-utils PATCH 5/7] fsck.gfs2: don't check newly created lost+found in pass2 Bob Peterson
2013-07-16 16:52 ` Andrew Price
2013-07-16 17:14 ` Bob Peterson
2013-07-16 12:56 ` [Cluster-devel] [gfs2-utils PATCH 6/7] fsck.gfs2: avoid negative number in leaf depth Bob Peterson
2013-07-16 12:56 ` [Cluster-devel] [gfs2-utils PATCH 7/7] fsck.gfs2: Detect and fix duplicate references in hash tables Bob Peterson
2013-07-16 16:52 ` Andrew Price
2013-07-16 17:16 ` Bob Peterson
2013-07-17 5:30 ` Fabio M. Di Nitto [this message]
2013-07-17 7:53 ` [Cluster-devel] [gfs2-utils PATCH 1/7] fsck.gfs2: Fix reference to uninitialized variable Steven Whitehouse
2013-07-17 11:51 ` [Cluster-devel] [PATCH] fsck.gfs2: Don't rely on cluster.conf when rebuilding sb Andrew Price
2013-07-17 11:52 ` Steven Whitehouse
2013-07-17 12:27 ` Bob Peterson
2013-07-17 18:13 ` Fabio M. Di Nitto
2013-07-17 18:26 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E62BF2.5070007@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).