From: Lon Hohberger <lhh@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range
Date: Mon, 09 Sep 2013 15:32:53 -0400 [thread overview]
Message-ID: <522E2265.7040807@redhat.com> (raw)
In-Reply-To: <1378226918-9051-1-git-send-email-jpokorny@redhat.com>
Yes, this is right. I'm not sure why I limited the port ranges - and
differently, depending on where you look in the code.
This should be merged.
-- Lon
On 09/03/2013 12:48 PM, Jan Pokorn? wrote:
> Signed-off-by: Jan Pokorn? <jpokorny@redhat.com>
> ---
> client/options.c | 2 +-
> server/config.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/client/options.c b/client/options.c
> index 653fae4..a44c15f 100644
> --- a/client/options.c
> +++ b/client/options.c
> @@ -134,7 +134,7 @@ assign_port(fence_virt_args_t *args, struct arg_info *arg, char *value)
> return;
>
> args->net.port = atoi(value);
> - if (args->net.port <= 0 || args->net.port >= 65500) {
> + if (args->net.port <= 0 || args->net.port >= 65536) {
> printf("Invalid port: '%s'\n", value);
> args->flags |= F_ERR;
> }
> diff --git a/server/config.c b/server/config.c
> index 87d826e..6ba8b6d 100644
> --- a/server/config.c
> +++ b/server/config.c
> @@ -239,7 +239,7 @@ listener_config_multicast(config_object_t *config)
> text_input("Multicast IP Port", val, inp, sizeof(inp));
>
> done = atoi(inp);
> - if (done <= 0 || done > 65534) {
> + if (done <= 0 || done >= 65536) {
> printf("Port value '%s' is out of range\n", val);
> continue;
> }
>
prev parent reply other threads:[~2013-09-09 19:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 16:48 [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range Jan Pokorný
2013-09-09 19:32 ` Lon Hohberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522E2265.7040807@redhat.com \
--to=lhh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).