* [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range
@ 2013-09-03 16:48 Jan Pokorný
2013-09-09 19:32 ` Lon Hohberger
0 siblings, 1 reply; 2+ messages in thread
From: Jan Pokorný @ 2013-09-03 16:48 UTC (permalink / raw)
To: cluster-devel.redhat.com
Signed-off-by: Jan Pokorn? <jpokorny@redhat.com>
---
client/options.c | 2 +-
server/config.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/options.c b/client/options.c
index 653fae4..a44c15f 100644
--- a/client/options.c
+++ b/client/options.c
@@ -134,7 +134,7 @@ assign_port(fence_virt_args_t *args, struct arg_info *arg, char *value)
return;
args->net.port = atoi(value);
- if (args->net.port <= 0 || args->net.port >= 65500) {
+ if (args->net.port <= 0 || args->net.port >= 65536) {
printf("Invalid port: '%s'\n", value);
args->flags |= F_ERR;
}
diff --git a/server/config.c b/server/config.c
index 87d826e..6ba8b6d 100644
--- a/server/config.c
+++ b/server/config.c
@@ -239,7 +239,7 @@ listener_config_multicast(config_object_t *config)
text_input("Multicast IP Port", val, inp, sizeof(inp));
done = atoi(inp);
- if (done <= 0 || done > 65534) {
+ if (done <= 0 || done >= 65536) {
printf("Port value '%s' is out of range\n", val);
continue;
}
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range
2013-09-03 16:48 [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range Jan Pokorný
@ 2013-09-09 19:32 ` Lon Hohberger
0 siblings, 0 replies; 2+ messages in thread
From: Lon Hohberger @ 2013-09-09 19:32 UTC (permalink / raw)
To: cluster-devel.redhat.com
Yes, this is right. I'm not sure why I limited the port ranges - and
differently, depending on where you look in the code.
This should be merged.
-- Lon
On 09/03/2013 12:48 PM, Jan Pokorn? wrote:
> Signed-off-by: Jan Pokorn? <jpokorny@redhat.com>
> ---
> client/options.c | 2 +-
> server/config.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/client/options.c b/client/options.c
> index 653fae4..a44c15f 100644
> --- a/client/options.c
> +++ b/client/options.c
> @@ -134,7 +134,7 @@ assign_port(fence_virt_args_t *args, struct arg_info *arg, char *value)
> return;
>
> args->net.port = atoi(value);
> - if (args->net.port <= 0 || args->net.port >= 65500) {
> + if (args->net.port <= 0 || args->net.port >= 65536) {
> printf("Invalid port: '%s'\n", value);
> args->flags |= F_ERR;
> }
> diff --git a/server/config.c b/server/config.c
> index 87d826e..6ba8b6d 100644
> --- a/server/config.c
> +++ b/server/config.c
> @@ -239,7 +239,7 @@ listener_config_multicast(config_object_t *config)
> text_input("Multicast IP Port", val, inp, sizeof(inp));
>
> done = atoi(inp);
> - if (done <= 0 || done > 65534) {
> + if (done <= 0 || done >= 65536) {
> printf("Port value '%s' is out of range\n", val);
> continue;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-09 19:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-03 16:48 [Cluster-devel] [fence-virt][PATCH] Fix supported TCP/multicast port range Jan Pokorný
2013-09-09 19:32 ` Lon Hohberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).