* [Cluster-devel] [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null()
@ 2013-11-15 4:34 Jeff Liu
0 siblings, 0 replies; only message in thread
From: Jeff Liu @ 2013-11-15 4:34 UTC (permalink / raw)
To: cluster-devel.redhat.com
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/jfs/jfs_logmgr.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
* write or queue the full page at the tail of write queue
*/
/* get the tail tblk on commit queue */
- if (list_empty(&log->cqueue))
- tblk = NULL;
- else
- tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+ tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
/* every tblk who has COMMIT record on the current page,
* and has not been committed, must be on commit queue
--
1.8.3.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-15 4:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 4:34 [Cluster-devel] [PATCH 5/6] jfs: simplify lmNextPage() via list_last_entry_or_null() Jeff Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).