From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Liu Date: Fri, 15 Nov 2013 12:35:15 +0800 Subject: [Cluster-devel] [PATCH 6/6] jfs: simplify lmLogSync() via list_last_entry_or_null() Message-ID: <5285A483.3040009@oracle.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit From: Jie Liu Simplify the code in lmLogSync() via list_last_entry_or_null(). Signed-off-by: Jie Liu --- fs/jfs/jfs_logmgr.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 7b565d0..2f90779 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -963,13 +963,9 @@ static int lmLogSync(struct jfs_log * log, int hard_sync) if (log->sync == log->syncpt) { LOGSYNC_LOCK(log, flags); - if (list_empty(&log->synclist)) - log->sync = log->lsn; - else { - lp = list_entry(log->synclist.next, - struct logsyncblk, synclist); - log->sync = lp->lsn; - } + lp = list_last_entry_or_null(&log->synclist, struct logsyncblk, + synclist); + log->sync = lp ? lp->lsn : log->lsn; LOGSYNC_UNLOCK(log, flags); } -- 1.8.3.2