From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/2] fence_ipmilan: port fencing agent to fencing library
Date: Fri, 22 Nov 2013 19:35:16 +0100 [thread overview]
Message-ID: <528FA3E4.8030507@redhat.com> (raw)
In-Reply-To: <20131122161850.GC9777@redhat.com>
On 11/22/2013 5:18 PM, Jan Pokorn? wrote:
> On 21/11/13 16:48 +0100, Fabio M. Di Nitto wrote:
>> On 11/21/2013 4:16 PM, Ondrej Mular wrote:
>>> +PATHS = ["/usr/local/bull/NSMasterHW/bin/ipmitool",
>>> + "/usr/bin/ipmitool",
>>> + "/usr/sbin/ipmitool",
>>> + "/bin/ipmitool",
>>> + "/sbin/ipmitool",
>>> + "/usr/local/bin/ipmitool",
>>> + "/usr/local/sbin/ipmitool"]
>>
>> this hard-cording it bad.
>>
>> Always use OS define PATH and if really necessary allow user to override
>> with an option (for example: --pathtoipmitool=/usr/local....)
>
> see, e.g.,
> http://git.engineering.redhat.com/users/jpokorny/clufter/tree/utils.py?id=d37db7470f4e44598af0b91d02221182178677ff#n22
> that mimics "which" standard utility
>
> Hope this helps
>
I?d like to understand why we need a search path in the first place tho
and we can?t just rely on shell hitting the right tool :)
Fabio
next prev parent reply other threads:[~2013-11-22 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1466780058.2338929.1385045970240.JavaMail.root@redhat.com>
2013-11-21 15:16 ` [Cluster-devel] [PATCH 1/2] fence_ipmilan: port fencing agent to fencing library Ondrej Mular
2013-11-21 15:48 ` Fabio M. Di Nitto
2013-11-22 16:18 ` Jan Pokorný
2013-11-22 18:35 ` Fabio M. Di Nitto [this message]
2013-11-25 8:35 ` Jan Friesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528FA3E4.8030507@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).