From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bogdan Dobrelya Date: Wed, 18 Dec 2013 15:42:21 +0200 Subject: [Cluster-devel] Fw: some fence_virsh, fene_apc patches for RHEL6 backports In-Reply-To: <52AF18ED.8090906@redhat.com> References: <52A74740.8020904@redhat.com> <52A82671.1000604@mirantis.com> <52AF18ED.8090906@redhat.com> Message-ID: <52B1A63D.40203@mirantis.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 12/16/2013 05:14 PM, Marek Grac wrote: > Hi, > > Thanks for a patches, > > On 12/11/2013 09:46 AM, Bogdan Dobrelya wrote: >> Hello. >> Description for suggested patches: >> >>> fence_virsh: I believe the uuid support is a good idea, cuz every >>> spawned VM would have an UUID in its dmidecode, equal to its `virsh >>> domuuid`. Thus, to fence it, we should not either know the domain name, >>> nor query libvirt to find it out. >>> > Based on your patch, I have sent a new patch to cluster-devel@ ; the > main difference is that patch is based on current version (as there > were several changes vs RHEL6). The other difference is that I have > removed obtaining status of plug from list function because it can not > work easily with UUID. Instead we call directly 'virsh domstate' ; on > older systems there can be a problem with 'virsh --uuid --all' because > '--uuid' is relatively new (yes, supported in RHEL6+) so I did not use > this feature. Hello. I believe, the device opt for "uuid" should be added as well (see patch in attachment). Correct me, If I'm wrong... > >>> fence_apc: As I can see from my research activities, fence_apc is quite >>> a vendor specific agent, thus it would require custom options for >>> command-prompt as well as ssh-options. > --ssh-options are already available in upstream > > m, -- Best regards, Bogdan Dobrelya, Researcher TechLead, Mirantis, Inc. +38 (066) 051 07 53 Skype bogdando_at_yahoo.com Irc #bogdando 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru bdobrelia at mirantis.com -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Add-missed-uuid-device-opt.patch Type: text/x-patch Size: 883 bytes Desc: not available URL: