From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bogdan Dobrelya Date: Tue, 24 Dec 2013 15:23:30 +0200 Subject: [Cluster-devel] Fw: some fence_virsh, fene_apc patches for RHEL6 backports In-Reply-To: <52B2F0EA.5010609@redhat.com> References: <52A74740.8020904@redhat.com> <52A82671.1000604@mirantis.com> <52AF18ED.8090906@redhat.com> <52B1A63D.40203@mirantis.com> <52B2F0EA.5010609@redhat.com> Message-ID: <52B98AD2.8040903@mirantis.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 12/19/2013 03:13 PM, Marek Grac wrote: > On 12/18/2013 02:42 PM, Bogdan Dobrelya wrote: > >>> Based on your patch, I have sent a new patch to cluster-devel@ ; the >>> main difference is that patch is based on current version (as there >>> were several changes vs RHEL6). The other difference is that I have >>> removed obtaining status of plug from list function because it can >>> not work easily with UUID. Instead we call directly 'virsh domstate' >>> ; on older systems there can be a problem with 'virsh --uuid --all' >>> because '--uuid' is relatively new (yes, supported in RHEL6+) so I >>> did not use this feature. >> Hello. I believe, the device opt for "uuid" should be added as well >> (see patch in attachment). Correct me, If I'm wrong... > > Hi, > > The 'uuid' is detected automatically (via standard python uuid library) > so for user it enough to just enter it as --plug/-n. The > options["--uuid"] is filled automatically in fencing library if uuid is > detected. The same approach is used also in fence_vmware_soap. > > I know that documentation is the weak point and if everything will go as > planned, I should spend most of the January by writing first drafts. > > m, Hello. I've attached your uuid patch from master, backported to RHEL6 branch as well. I've tested it manually, by connecting to my libvirt host using -U , -n , -o list options. I hope we will see it for RHEL6 soon, uuid support is usefull feature. -- Best regards, Bogdan Dobrelya, Researcher TechLead, Mirantis, Inc. +38 (066) 051 07 53 Skype bogdando_at_yahoo.com Irc #bogdando 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru bdobrelia at mirantis.com -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-RHEL6-fence_virsh-Add-UUID-support-for-fence_virsh.patch Type: text/x-patch Size: 2708 bytes Desc: not available URL: