* [Cluster-devel] [gfs2_edit PATCH] gfs2_edit: mark log headers with the unmounted flag
2014-03-03 21:17 ` [Cluster-devel] [gfs2_edit PATCH] gfs2_edit: mark log headers with the unmounted flag Bob Peterson
@ 2014-03-04 11:43 ` Andrew Price
2014-03-07 13:29 ` Andrew Price
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Price @ 2014-03-04 11:43 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi Bob,
On 03/03/14 21:17, Bob Peterson wrote:
> Hi,
>
> This patch prints out "[UNMOUNTED]" next to log headers that have the
> unmounted flag set. That makes it much easier to determine the active
> part of a journal.
Looks good to me.
Cheers,
Andy
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/gfs2/edit/journal.c b/gfs2/edit/journal.c
> index 118d068..4dab61c 100644
> --- a/gfs2/edit/journal.c
> +++ b/gfs2/edit/journal.c
> @@ -573,10 +573,13 @@ void dump_journal(const char *journal, int tblk)
> check_journal_wrap(lh.lh_sequence,
> &highest_seq);
> print_gfs2("0x%llx (j+%4llx): Log header: Seq"
> - ": 0x%x, tail: 0x%x, blk: 0x%x",
> + ": 0x%x, tail: 0x%x, blk: 0x%x%s",
> abs_block, ((jb + wrappt) % j_size)
> / sbd.bsize, lh.lh_sequence,
> - lh.lh_tail, lh.lh_blkno);
> + lh.lh_tail, lh.lh_blkno,
> + lh.lh_flags ==
> + GFS2_LOG_HEAD_UNMOUNT ?
> + " [UNMOUNTED]" : "");
> }
> eol(0);
> } else if (sbd.gfs1 && ld_blocks > 0) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [Cluster-devel] [gfs2_edit PATCH] gfs2_edit: mark log headers with the unmounted flag
2014-03-03 21:17 ` [Cluster-devel] [gfs2_edit PATCH] gfs2_edit: mark log headers with the unmounted flag Bob Peterson
2014-03-04 11:43 ` Andrew Price
@ 2014-03-07 13:29 ` Andrew Price
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Price @ 2014-03-07 13:29 UTC (permalink / raw)
To: cluster-devel.redhat.com
On 03/03/14 21:17, Bob Peterson wrote:
> Hi,
>
> This patch prints out "[UNMOUNTED]" next to log headers that have the
> unmounted flag set. That makes it much easier to determine the active
> part of a journal.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
This is now in gfs2-utils.git/master
Cheers,
Andy
> ---
> diff --git a/gfs2/edit/journal.c b/gfs2/edit/journal.c
> index 118d068..4dab61c 100644
> --- a/gfs2/edit/journal.c
> +++ b/gfs2/edit/journal.c
> @@ -573,10 +573,13 @@ void dump_journal(const char *journal, int tblk)
> check_journal_wrap(lh.lh_sequence,
> &highest_seq);
> print_gfs2("0x%llx (j+%4llx): Log header: Seq"
> - ": 0x%x, tail: 0x%x, blk: 0x%x",
> + ": 0x%x, tail: 0x%x, blk: 0x%x%s",
> abs_block, ((jb + wrappt) % j_size)
> / sbd.bsize, lh.lh_sequence,
> - lh.lh_tail, lh.lh_blkno);
> + lh.lh_tail, lh.lh_blkno,
> + lh.lh_flags ==
> + GFS2_LOG_HEAD_UNMOUNT ?
> + " [UNMOUNTED]" : "");
> }
> eol(0);
> } else if (sbd.gfs1 && ld_blocks > 0) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread