[Cluster-devel] joining the gitfence-agents group

[Cluster-devel] joining the gitfence-agents group

[David Smith]

Hi marek, sure, no problem, here's the changes; also sent to cluster-devel.

I've already tested by manually running the fence-raritan agent that this
is working and functional

attached tgz for the raritan files (fence-agents/fence/agents/raritan/)


index eaef1d8..c24198c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -283,6 +283,7 @@ AC_CONFIG_FILES([Makefile
                 fence/agents/netio/Makefile
                 fence/agents/rackswitch/Makefile
                 fence/agents/ovh/Makefile
+                fence/agents/raritan/Makefile
                 fence/agents/rhevm/Makefile
                 fence/agents/rsa/Makefile
                 fence/agents/rsb/Makefile






On Wed, Mar 19, 2014 at 7:37 AM, Marek Grac <mgrac@redhat.com> wrote:

> On 03/18/2014 12:20 AM, David Smith wrote:
>
>> any chance you can sponsor and approve so i can submit the code via git?
>>
>> or, if you prefer, I can send you the code modifications.
>>
>>  Hi,
>
> sorry for late response,
>
> The write access to git repository is still limited to very small group of
> people and I will be happy to add you there after you become regular
> contributor. Currently, please send a patch to cluster-devel at redhat.comwhere code review will be done. After that review, we will add your code
> into upstream using git-am so you will be preserved as author.
>
> m,
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140319/9d2e3cc2/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: raritan.tgz
Type: application/x-gzip
Size: 1951 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140319/9d2e3cc2/attachment.bin>

[Cluster-devel] joining the gitfence-agents group

[Marek Grac]

Hi,

On 03/19/2014 10:26 PM, David Smith wrote:
> Hi marek, sure, no problem, here's the changes; also sent to 
> cluster-devel.

thanks, for next time it will be easier to you and other reviewers if 
you will sent a patch in a standard format. Take a look at
http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html

> I've already tested by manually running the fence-raritan agent that 
> this is working and functional
>
code looks pretty good and after few minor changes it can be accepted.

These are my comments:
     * please remove commented line of source code
     * exception checking 'Due to limitations ...' is not required any 
more because we have subpackage for every fence-agent so dependencies 
can be solved properly
     * default value can be now set more easier (--ipport in this case)
         all_opt["ipport"]["default"] = "23"
     * please add support also for delay before login which is very 
useful for 2-node clusters
         if options["--action"] in ["off", "reboot"]:
                 time.sleep(int(options["--delay"]))

m,

[Cluster-devel] joining the gitfence-agents group

[David Smith]

thanks, i was doing some thinking the other night, given the goal is for
this agent to work with oVirt, i'm not sure that all the oVirt required
commands are supported in the agent code for this to work.
Also there's a comment about the port being required as a large path, this
is very unlikely to work with oVirt, I need to consult that group to find
out and perhaps submit a newer version.



On Fri, Mar 21, 2014 at 10:50 AM, Marek Grac <mgrac@redhat.com> wrote:

> Hi,
>
>
> On 03/19/2014 10:26 PM, David Smith wrote:
>
>> Hi marek, sure, no problem, here's the changes; also sent to
>> cluster-devel.
>>
>
> thanks, for next time it will be easier to you and other reviewers if you
> will sent a patch in a standard format. Take a look at
> http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html
>
>
>  I've already tested by manually running the fence-raritan agent that this
>> is working and functional
>>
>>  code looks pretty good and after few minor changes it can be accepted.
>
> These are my comments:
>     * please remove commented line of source code
>     * exception checking 'Due to limitations ...' is not required any more
> because we have subpackage for every fence-agent so dependencies can be
> solved properly
>     * default value can be now set more easier (--ipport in this case)
>         all_opt["ipport"]["default"] = "23"
>     * please add support also for delay before login which is very useful
> for 2-node clusters
>         if options["--action"] in ["off", "reboot"]:
>                 time.sleep(int(options["--delay"]))
>
> m,
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140321/d06cf7f5/attachment.htm>

[Cluster-devel] joining the gitfence-agents group

[David Smith]

Hi Marek,

Made the suggestions you've requested and did a quick test, all seems to
work.
attached is the new file


On Fri, Mar 21, 2014 at 3:50 AM, Marek Grac <mgrac@redhat.com> wrote:

> Hi,
>
>
> On 03/19/2014 10:26 PM, David Smith wrote:
>
>> Hi marek, sure, no problem, here's the changes; also sent to
>> cluster-devel.
>>
>
> thanks, for next time it will be easier to you and other reviewers if you
> will sent a patch in a standard format. Take a look at
> http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html
>
>
>  I've already tested by manually running the fence-raritan agent that this
>> is working and functional
>>
>>  code looks pretty good and after few minor changes it can be accepted.
>
> These are my comments:
>     * please remove commented line of source code
>     * exception checking 'Due to limitations ...' is not required any more
> because we have subpackage for every fence-agent so dependencies can be
> solved properly
>     * default value can be now set more easier (--ipport in this case)
>         all_opt["ipport"]["default"] = "23"
>     * please add support also for delay before login which is very useful
> for 2-node clusters
>         if options["--action"] in ["off", "reboot"]:
>                 time.sleep(int(options["--delay"]))
>
> m,
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140325/0a8dd293/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: raritan.tgz
Type: application/x-gzip
Size: 1645 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140325/0a8dd293/attachment.bin>

[Cluster-devel] joining the gitfence-agents group

[David Smith]

Hi Marek,

Have you had a chance to review the changes?  I'd love to see this get put
into fence-agents for support in oVirt 3.x


On Tue, Mar 25, 2014 at 2:56 PM, David Smith <dsmith@mypchelp.com> wrote:

> Hi Marek,
>
> Made the suggestions you've requested and did a quick test, all seems to
> work.
> attached is the new file
>
>
> On Fri, Mar 21, 2014 at 3:50 AM, Marek Grac <mgrac@redhat.com> wrote:
>
>> Hi,
>>
>>
>> On 03/19/2014 10:26 PM, David Smith wrote:
>>
>>> Hi marek, sure, no problem, here's the changes; also sent to
>>> cluster-devel.
>>>
>>
>> thanks, for next time it will be easier to you and other reviewers if you
>> will sent a patch in a standard format. Take a look at
>> http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html
>>
>>
>>  I've already tested by manually running the fence-raritan agent that
>>> this is working and functional
>>>
>>>  code looks pretty good and after few minor changes it can be accepted.
>>
>> These are my comments:
>>     * please remove commented line of source code
>>     * exception checking 'Due to limitations ...' is not required any
>> more because we have subpackage for every fence-agent so dependencies can
>> be solved properly
>>     * default value can be now set more easier (--ipport in this case)
>>         all_opt["ipport"]["default"] = "23"
>>     * please add support also for delay before login which is very useful
>> for 2-node clusters
>>         if options["--action"] in ["off", "reboot"]:
>>                 time.sleep(int(options["--delay"]))
>>
>> m,
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140401/b0aedd45/attachment.htm>

[Cluster-devel] joining the gitfence-agents group

[Marek Grac]

On 03/25/2014 10:56 PM, David Smith wrote:
> Hi Marek,
>
> Made the suggestions you've requested and did a quick test, all seems 
> to work.
> attached is the new file
>
Thanks, fence agent is now in upstream, fedora release will follow soon

m,

>
> On Fri, Mar 21, 2014 at 3:50 AM, Marek Grac <mgrac@redhat.com 
> <mailto:mgrac@redhat.com>> wrote:
>
>     Hi,
>
>
>     On 03/19/2014 10:26 PM, David Smith wrote:
>
>         Hi marek, sure, no problem, here's the changes; also sent to
>         cluster-devel.
>
>
>     thanks, for next time it will be easier to you and other reviewers
>     if you will sent a patch in a standard format. Take a look at
>     http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html
>
>
>
>         I've already tested by manually running the fence-raritan
>         agent that this is working and functional
>
>     code looks pretty good and after few minor changes it can be accepted.
>
>     These are my comments:
>         * please remove commented line of source code
>         * exception checking 'Due to limitations ...' is not required
>     any more because we have subpackage for every fence-agent so
>     dependencies can be solved properly
>         * default value can be now set more easier (--ipport in this case)
>             all_opt["ipport"]["default"] = "23"
>         * please add support also for delay before login which is very
>     useful for 2-node clusters
>             if options["--action"] in ["off", "reboot"]:
>                     time.sleep(int(options["--delay"]))
>
>     m,
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140402/444e829b/attachment.htm>