From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Grac <mgrac@redhat.com>
Date: Fri, 21 Mar 2014 11:50:59 +0100
Subject: [Cluster-devel] joining the gitfence-agents group
In-Reply-To: <CAMKtzE8CdzZVVYQ49qUhsRonkggL64_5FNd28kFN5tRy7eJAqg@mail.gmail.com>
References: <CAMKtzE9pjic-cXah9_wKbEhxVmcQj+K4fH88voSdfKP4dPjLfw@mail.gmail.com>	<5329ABBE.70304@redhat.com>
	<CAMKtzE8CdzZVVYQ49qUhsRonkggL64_5FNd28kFN5tRy7eJAqg@mail.gmail.com>
Message-ID: <532C1993.70503@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On 03/19/2014 10:26 PM, David Smith wrote:
> Hi marek, sure, no problem, here's the changes; also sent to 
> cluster-devel.

thanks, for next time it will be easier to you and other reviewers if 
you will sent a patch in a standard format. Take a look at
http://alblue.bandlem.com/2011/12/git-tip-of-week-patches-by-email.html

> I've already tested by manually running the fence-raritan agent that 
> this is working and functional
>
code looks pretty good and after few minor changes it can be accepted.

These are my comments:
     * please remove commented line of source code
     * exception checking 'Due to limitations ...' is not required any 
more because we have subpackage for every fence-agent so dependencies 
can be solved properly
     * default value can be now set more easier (--ipport in this case)
         all_opt["ipport"]["default"] = "23"
     * please add support also for delay before login which is very 
useful for 2-node clusters
         if options["--action"] in ["off", "reboot"]:
                 time.sleep(int(options["--delay"]))

m,