From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fencing: Replace printing to stderr with proper logging solution
Date: Thu, 03 Apr 2014 11:22:33 +0200 [thread overview]
Message-ID: <533D2859.6090703@redhat.com> (raw)
In-Reply-To: <533D2299.9080408@redhat.com>
On 4/3/2014 10:58 AM, Marek Grac wrote:
> On 04/02/2014 08:14 PM, Fabio M. Di Nitto wrote:
>> On 04/02/2014 05:06 PM, Marek 'marx' Grac wrote:
>>> This patch replaces local solutions by standard python logging
>>> module. Levels of messages is not final, it just reflects the
>>> previous state. So, debug level is available only with -v /
>>> verbose option.
>> Hi Marek,
>>
>> are we keeping out-of-tree agents in sync too? specifically
>> fence_virt and fence_sanlock.
> This solution does not change behaviour of fence agents, it is
> more internal thing which is python based so there is no need to
> change anything else.
Right, I understand.
> After we will found out where to add logging and to which levels
> (ERROR, INFO, DEBUG) then it will be good to make other agents work
> in same way.
That?s what I care effectively. Keep it consistent across all agents.
Perhaps we should consider moving fence_sanlock and fence-virt into
fence-agents now that the fence-agents srpm generates many separated
rpm. It will make it easier to keep all features in sync across the board.
Fabio
prev parent reply other threads:[~2014-04-03 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 15:06 [Cluster-devel] [PATCH] fencing: Replace printing to stderr with proper logging solution Marek 'marx' Grac
2014-04-02 18:14 ` Fabio M. Di Nitto
2014-04-03 8:58 ` Marek Grac
2014-04-03 9:22 ` Fabio M. Di Nitto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D2859.6090703@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).