cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] GFS2: Take account of blockages when using reserved blocks
Date: Tue, 31 Jul 2012 08:41:30 -0400 (EDT)	[thread overview]
Message-ID: <534880209.6704615.1343738490765.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1343643981.2726.13.camel@menhir>

----- Original Message -----
| 
| The claim_reserved_blks() function was not taking account of
| the possibility of "blockages" while performing allocation.
| This can be caused by another node allocating something in
| the same extent which has been reserved locally.
| 
| This patch tests for this condition and then skips the remainder
| of the reservation in this case. This is a relatively rare event,
| so that it should not affect the general performance improvement
| which the block reservations provide.
| 
| The claim_reserved_blks() function also appears not to be able
| to deal with reservations which cross bitmap boundaries, but
| that can be dealt with in a future patch since we don't generate
| boundary crossing reservations currently.
| 
| Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
| Reported-by: David Teigland <teigland@redhat.com>
| Cc: Bob Peterson <rpeterso@redhat.com>

Hi,

ACK to both patches.

I've done a fair amount of testing with these two patches.

Regards,

Bob Peterson
Red Hat File Systems



      reply	other threads:[~2012-07-31 12:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 10:26 [Cluster-devel] GFS2: Take account of blockages when using reserved blocks Steven Whitehouse
2012-07-31 12:41 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534880209.6704615.1343738490765.JavaMail.root@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).