From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Tue, 31 Jul 2012 08:41:30 -0400 (EDT) Subject: [Cluster-devel] GFS2: Take account of blockages when using reserved blocks In-Reply-To: <1343643981.2726.13.camel@menhir> Message-ID: <534880209.6704615.1343738490765.JavaMail.root@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | | The claim_reserved_blks() function was not taking account of | the possibility of "blockages" while performing allocation. | This can be caused by another node allocating something in | the same extent which has been reserved locally. | | This patch tests for this condition and then skips the remainder | of the reservation in this case. This is a relatively rare event, | so that it should not affect the general performance improvement | which the block reservations provide. | | The claim_reserved_blks() function also appears not to be able | to deal with reservations which cross bitmap boundaries, but | that can be dealt with in a future patch since we don't generate | boundary crossing reservations currently. | | Signed-off-by: Steven Whitehouse | Reported-by: David Teigland | Cc: Bob Peterson Hi, ACK to both patches. I've done a fair amount of testing with these two patches. Regards, Bob Peterson Red Hat File Systems