[Cluster-devel] [PATCH 5/5] libgfs2: Remove logging API

[Andrew Price <anprice@redhat.com>]

On 07/05/14 16:07, Andrew Price wrote:
> On 07/05/14 15:55, Bob Peterson wrote:
>> ----- Original Message -----
>>> libgfs2 was exposing a logging API (log_info, etc.) but wasn't using it
>>> itself. Remove the logging bits and move them into
>>> gfs2/include/logging.h
>>>
>>> Signed-off-by: Andrew Price <anprice@redhat.com>
>>
>> All five patches look okay to me.
>> I'm a little apprehensive about removing some of the debug capabilities,
>> like having gfs2_grow show details about the new rgrps, but we can
>> likely get the same information from gfs2_edit.
>
> Yes, I've been thinking a bit about increasing the amount of debugging
> output we can get from libgfs2 now that the logging bits are less
> entangled. One tempting idea is to be able to switch on debug output
> with an environment variable, e.g. LGFS2_DEBUG=1 gfs2_grow /delibgfs2 v/foo

Hm, not sure what happened there. It should have been "LGFS2_DEBUG=1 
gfs2_grow /dev/foo"

Andy