* [Cluster-devel] [gfs2-utils PATCH] fsck.gfs2: Issue read-ahead for dinodes in each bitmap
[not found] <1506544850.6310017.1405011313054.JavaMail.zimbra@redhat.com>
@ 2014-07-10 16:56 ` Bob Peterson
2014-07-11 16:07 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2014-07-10 16:56 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This patch speeds up fsck.gfs2 by issuing read-ahead for each of the
dinodes found in each of the bitmaps, prior to processing the bitmap.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
gfs2/fsck/pass1.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck/pass1.c
index fec2f64..90ca357 100644
--- a/gfs2/fsck/pass1.c
+++ b/gfs2/fsck/pass1.c
@@ -1442,6 +1442,10 @@ static int pass1_process_bitmap(struct gfs2_sbd *sdp, struct rgrp_tree *rgd, uin
struct gfs2_inode *ip;
uint8_t q;
+ /* Issue read-ahead for all dinodes in this bitmap */
+ for (i = 0; i < n; i++)
+ posix_fadvise(sdp->device_fd, ibuf[i] * sdp->bsize, sdp->bsize,
+ POSIX_FADV_WILLNEED);
for (i = 0; i < n; i++) {
int is_inode;
uint32_t check_magic;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [gfs2-utils PATCH] fsck.gfs2: Issue read-ahead for dinodes in each bitmap
2014-07-10 16:56 ` [Cluster-devel] [gfs2-utils PATCH] fsck.gfs2: Issue read-ahead for dinodes in each bitmap Bob Peterson
@ 2014-07-11 16:07 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2014-07-11 16:07 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
On 10/07/14 17:56, Bob Peterson wrote:
> Hi,
>
> This patch speeds up fsck.gfs2 by issuing read-ahead for each of the
> dinodes found in each of the bitmaps, prior to processing the bitmap.
Looks good to me,
Steve.
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> gfs2/fsck/pass1.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/gfs2/fsck/pass1.c b/gfs2/fsck/pass1.c
> index fec2f64..90ca357 100644
> --- a/gfs2/fsck/pass1.c
> +++ b/gfs2/fsck/pass1.c
> @@ -1442,6 +1442,10 @@ static int pass1_process_bitmap(struct gfs2_sbd *sdp, struct rgrp_tree *rgd, uin
> struct gfs2_inode *ip;
> uint8_t q;
>
> + /* Issue read-ahead for all dinodes in this bitmap */
> + for (i = 0; i < n; i++)
> + posix_fadvise(sdp->device_fd, ibuf[i] * sdp->bsize, sdp->bsize,
> + POSIX_FADV_WILLNEED);
> for (i = 0; i < n; i++) {
> int is_inode;
> uint32_t check_magic;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-11 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1506544850.6310017.1405011313054.JavaMail.zimbra@redhat.com>
2014-07-10 16:56 ` [Cluster-devel] [gfs2-utils PATCH] fsck.gfs2: Issue read-ahead for dinodes in each bitmap Bob Peterson
2014-07-11 16:07 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).