From: Christine Caulfield <ccaulfie@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] dlm: clear out addrs before calling into corosync
Date: Fri, 05 Sep 2014 09:47:00 +0100 [thread overview]
Message-ID: <54097884.9010807@redhat.com> (raw)
The corosync_cfg_get_node_addrs() call does not fill the whole of the
addrs field passed in, specifically it only writes the the address
family and IP address, leaving the port number untouched.
If the port number contains junk, then that can get passed into the
kernel by dlm_controld where it is subsequently used in the comparison
that checks for valid cluster nodes in a connection. If this happens
then an otherwise valid connection can be rejected and the dlm will hang.
I've seen this quite often on s390 but I don't see any reason why it
might not also be causing intermittent connection problems on other archs.
Signed-Off-By: Christine Caulfield <ccaulfie@redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dlm_members_clear_addr.patch
Type: text/x-patch
Size: 440 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20140905/1a4937c3/attachment.bin>
reply other threads:[~2014-09-05 8:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54097884.9010807@redhat.com \
--to=ccaulfie@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).