From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Thu, 11 Sep 2014 13:42:13 +0100
Subject: [Cluster-devel] [PATCH] GFS2: Hash the negative dentry during
	inode lookup
In-Reply-To: <20140910183218.A7D7283F44@bcodding-csb.redhat.com>
References: <20140910183218.A7D7283F44@bcodding-csb.redhat.com>
Message-ID: <541198A5.2040000@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

On 10/09/14 19:09, Benjamin Coddington wrote:
> Fix a regression introduced by:
> 6d4ade986f9c8df31e68 GFS2: Add atomic_open support
> where an early return misses d_splice_alias() which had been
> adding the negative dentry.
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> ---
>   fs/gfs2/inode.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index e62e594..9317ddc 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -840,8 +840,10 @@ static struct dentry *__gfs2_lookup(struct inode *dir, struct dentry *dentry,
>   	int error;
>   
>   	inode = gfs2_lookupi(dir, &dentry->d_name, 0);
> -	if (!inode)
> +	if (inode == NULL) {
> +		d_add(dentry, NULL);
>   		return NULL;
> +	}
>   	if (IS_ERR(inode))
>   		return ERR_CAST(inode);
>   

Now in the GFS2 -nmw tree, and I've added Bob's signed-off-by too. Thanks,

Steve.