From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Wed, 22 Oct 2014 11:50:39 +0100 Subject: [Cluster-devel] [PATCH][try6] VFS: new want_holesize and got_holesize buffer_head flags for fiemap In-Reply-To: <20141022060434.GA11237@infradead.org> References: <635673293.9099204.1413939501068.JavaMail.zimbra@redhat.com> <579956475.9102148.1413940195344.JavaMail.zimbra@redhat.com> <20141022060434.GA11237@infradead.org> Message-ID: <54478BFF.8070608@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On 22/10/14 07:04, Christoph Hellwig wrote: > This looks like a big indicator that get_blocks is the wrong > interface for fiemap. > The question is then, what a better interface would look like? We could have "get_hole" as an extra operation I suppose. Not sure that I really see why thats better or worse than the extra flag at the moment? or did you have something else in mind? Steve.