From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Tue, 13 Jan 2015 10:54:04 +0000 Subject: [Cluster-devel] [PATCH] gfs2: fix sprintf format specifier In-Reply-To: <54B3A96F.3000702@huawei.com> References: <54B3A96F.3000702@huawei.com> Message-ID: <54B4F94C.7060000@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, On 12/01/15 11:01, alex chen wrote: > Sprintf format specifier "%d" and "%u" are mixed up in > gfs2_recovery_done() and freeze_show(). So correct them. > > Signed-off-by: Alex Chen > Reviewed-by: Joseph Qi Now in the GFS2 -nmw tree. Thanks, Steve. > --- > fs/gfs2/recovery.c | 2 +- > fs/gfs2/sys.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index 573bd3b..1b64577 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -439,7 +439,7 @@ static void gfs2_recovery_done(struct gfs2_sbd *sdp, unsigned int jid, > > ls->ls_recover_jid_done = jid; > ls->ls_recover_jid_status = message; > - sprintf(env_jid, "JID=%d", jid); > + sprintf(env_jid, "JID=%u", jid); > sprintf(env_status, "RECOVERY=%s", > message == LM_RD_SUCCESS ? "Done" : "Failed"); > kobject_uevent_env(&sdp->sd_kobj, KOBJ_CHANGE, envp); > diff --git a/fs/gfs2/sys.c b/fs/gfs2/sys.c > index 3ab566b..ae8e881 100644 > --- a/fs/gfs2/sys.c > +++ b/fs/gfs2/sys.c > @@ -96,7 +96,7 @@ static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf) > struct super_block *sb = sdp->sd_vfs; > int frozen = (sb->s_writers.frozen == SB_UNFROZEN) ? 0 : 1; > > - return snprintf(buf, PAGE_SIZE, "%u\n", frozen); > + return snprintf(buf, PAGE_SIZE, "%d\n", frozen); > } > > static ssize_t freeze_store(struct gfs2_sbd *sdp, const char *buf, size_t len)