* [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto
[not found] <1232858145.13594871.1421943047836.JavaMail.zimbra@redhat.com>
@ 2015-01-22 16:11 ` Bob Peterson
2015-01-26 21:00 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2015-01-22 16:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This patch just removes a goto that did nothing.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9054002..73c72253 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
}
error = gfs2_dir_add(&dip->i_inode, name, ip, da);
- if (error)
- goto fail_end_trans;
-fail_end_trans:
gfs2_trans_end(sdp);
fail_ipreserv:
gfs2_inplace_release(dip);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto
2015-01-22 16:11 ` [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto Bob Peterson
@ 2015-01-26 21:00 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2015-01-26 21:00 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 22/01/15 16:11, Bob Peterson wrote:
> Hi,
>
> This patch just removes a goto that did nothing.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 9054002..73c72253 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
> }
>
> error = gfs2_dir_add(&dip->i_inode, name, ip, da);
> - if (error)
> - goto fail_end_trans;
>
> -fail_end_trans:
> gfs2_trans_end(sdp);
> fail_ipreserv:
> gfs2_inplace_release(dip);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-26 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1232858145.13594871.1421943047836.JavaMail.zimbra@redhat.com>
2015-01-22 16:11 ` [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto Bob Peterson
2015-01-26 21:00 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).