From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Date: Mon, 26 Jan 2015 21:00:37 +0000
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Eliminate a nonsense goto
In-Reply-To: <1822797357.13595283.1421943115036.JavaMail.zimbra@redhat.com>
References: <1822797357.13595283.1421943115036.JavaMail.zimbra@redhat.com>
Message-ID: <54C6AAF5.6010409@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

Now in the -nmw git tree. Thanks,

Steve.

On 22/01/15 16:11, Bob Peterson wrote:
> Hi,
>
> This patch just removes a goto that did nothing.
>
> Regards,
>
> Bob Peterson
> Red Hat File Systems
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 9054002..73c72253 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
>   	}
>   
>   	error = gfs2_dir_add(&dip->i_inode, name, ip, da);
> -	if (error)
> -		goto fail_end_trans;
>   
> -fail_end_trans:
>   	gfs2_trans_end(sdp);
>   fail_ipreserv:
>   	gfs2_inplace_release(dip);
>