* [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl()
@ 2015-02-09 17:53 Andrew Elble
2015-02-10 10:44 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Elble @ 2015-02-09 17:53 UTC (permalink / raw)
To: cluster-devel.redhat.com
Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure")
Reported-by: Eric Meddaugh <etmsys@rit.edu>
Tested-by: Eric Meddaugh <etmsys@rit.edu>
Signed-off-by: Andrew Elble <aweits@rit.edu>
---
fs/gfs2/acl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index 3088e2a..7b31430 100644
--- a/fs/gfs2/acl.c
+++ b/fs/gfs2/acl.c
@@ -73,7 +73,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
BUG_ON(name == NULL);
- if (acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
+ if (acl && acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
return -E2BIG;
if (type == ACL_TYPE_ACCESS) {
--
1.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl()
2015-02-09 17:53 [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl() Andrew Elble
@ 2015-02-10 10:44 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2015-02-10 10:44 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On 09/02/15 17:53, Andrew Elble wrote:
> Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure")
> Reported-by: Eric Meddaugh <etmsys@rit.edu>
> Tested-by: Eric Meddaugh <etmsys@rit.edu>
> Signed-off-by: Andrew Elble <aweits@rit.edu>
> ---
> fs/gfs2/acl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
> index 3088e2a..7b31430 100644
> --- a/fs/gfs2/acl.c
> +++ b/fs/gfs2/acl.c
> @@ -73,7 +73,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type)
>
> BUG_ON(name == NULL);
>
> - if (acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
> + if (acl && acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode)))
> return -E2BIG;
>
> if (type == ACL_TYPE_ACCESS) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-10 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-09 17:53 [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl() Andrew Elble
2015-02-10 10:44 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).