From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Tue, 10 Feb 2015 10:44:28 +0000 Subject: [Cluster-devel] [PATCH] Fix crash during ACL deletion in acl max entry check in gfs2_set_acl() In-Reply-To: <1423504384-47404-1-git-send-email-aweits@rit.edu> References: <1423504384-47404-1-git-send-email-aweits@rit.edu> Message-ID: <54D9E10C.1080903@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Now in the -nmw git tree. Thanks, Steve. On 09/02/15 17:53, Andrew Elble wrote: > Fixes: e01580bf9e ("gfs2: use generic posix ACL infrastructure") > Reported-by: Eric Meddaugh > Tested-by: Eric Meddaugh > Signed-off-by: Andrew Elble > --- > fs/gfs2/acl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c > index 3088e2a..7b31430 100644 > --- a/fs/gfs2/acl.c > +++ b/fs/gfs2/acl.c > @@ -73,7 +73,7 @@ int gfs2_set_acl(struct inode *inode, struct posix_acl *acl, int type) > > BUG_ON(name == NULL); > > - if (acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode))) > + if (acl && acl->a_count > GFS2_ACL_MAX_ENTRIES(GFS2_SB(inode))) > return -E2BIG; > > if (type == ACL_TYPE_ACCESS) {