[Cluster-devel] [PATCH 2/2] gfs2_edit: Include dirent.de_rahead in directory listings

[Andrew Price <anprice@redhat.com>]

On 09/09/15 16:55, Andreas Gruenbacher wrote:
> When dumping a directory, for directory each entry, also print how many blocks
> of metadata can be read ahead when reading in the inode the entry points at.
>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
>   gfs2/edit/extended.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gfs2/edit/extended.c b/gfs2/edit/extended.c
> index e5cb12c..7a219ee 100644
> --- a/gfs2/edit/extended.c
> +++ b/gfs2/edit/extended.c
> @@ -342,13 +342,14 @@ static int display_leaf(struct iinfo *ind)
>   					strcpy(edit_fmt, "%llx");
>   				}
>   			}
> -			print_gfs2("%d/%d [%08x] %lld/%lld (0x%llx/0x%llx): ",
> +			print_gfs2("%d/%d [%08x] %lld/%lld (0x%llx/0x%llx) +%d: ",
>   				   total_dirents, d + 1,
>   				   ind->ii[0].dirent[d].dirent.de_hash,
>   				   ind->ii[0].dirent[d].dirent.de_inum.no_formal_ino,
>   				   ind->ii[0].dirent[d].block,
>   				   ind->ii[0].dirent[d].dirent.de_inum.no_formal_ino,
> -				   ind->ii[0].dirent[d].block);
> +				   ind->ii[0].dirent[d].block,
> +				   (unsigned int)ind->ii[0].dirent[d].dirent.de_rahead);

It would be better to use %u for an unsigned int. We don't have 
__attribute__((format(printf...))) on print_gfs2 yet but it would catch 
that.

Besides that, both patches look good.

Andy

>   		}
>   		print_inode_type(ind->ii[0].dirent[d].dirent.de_type);
>   		print_gfs2(" %s", ind->ii[0].dirent[d].filename);
>