From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Price <anprice@redhat.com>
Date: Fri, 11 Sep 2015 12:28:56 +0100
Subject: [Cluster-devel] gfs2 on-disk headers in user space
In-Reply-To: <CAHc6FU62_oZPOvdvd81y2H5sLLzr78GrE-u8ErDrrwvbVUe-gA@mail.gmail.com>
References: <1441814130-14786-1-git-send-email-andreas.gruenbacher@gmail.com>
	<1441814130-14786-2-git-send-email-andreas.gruenbacher@gmail.com>
	<55F05E01.3030205@redhat.com>
	<CAHc6FU6rne1uDXDF-sEmoCLVYF3=zroFXK37DQm7=D1sOxGGVQ@mail.gmail.com>
	<55F2B0BA.3090109@redhat.com>
	<CAHc6FU62_oZPOvdvd81y2H5sLLzr78GrE-u8ErDrrwvbVUe-gA@mail.gmail.com>
Message-ID: <55F2BAF8.408@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 11/09/15 12:02, Andreas Gruenbacher wrote:
> 2015-09-11 12:45 GMT+02:00 Andrew Price <anprice@redhat.com>:
>> Yes, I think ideally we should have a set of userspace structures to keep
>> things separate.
>
> Building gfs2-utils currently also depends on
> /usr/include/linux/gfs2_ondisk.h, so when building on an old system,
> some features will be disabled. It would be more useful to keep an
> up-to-date copy of that header in gfs2-utils: we have all the code to
> support all features in there anyway, and gfs2-utils needs to remain
> backwards compatible anyway.

That makes sense to me. I assume we would remove the #include 
<linux/types.h> from gfs2_ondisk.h and replace it with our own user 
space types header. I'm worried about clashes using the kernel type 
names though, so we might need to process the header somehow to change them.

Andy