From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] mkfs.gfs2: Add a progress indicator to mkfs.gfs2
Date: Mon, 12 Oct 2015 16:37:47 +0100 [thread overview]
Message-ID: <561BD3CB.8070209@redhat.com> (raw)
In-Reply-To: <561A65FD.9000609@redhat.com>
On 11/10/15 14:37, Paul Evans wrote:
> On 25/09/15 09:38, Andrew Price wrote:
>> Would a running rgrp count/total be a more natural progress indicator
>> than the rgrp address I wonder?
>
> I would agree that a running rgrp count/total would be a more natural
> progress but I did not see a way to check the total number of resource
> groups that were needed. It appears that the total is only known after
> all the rgrps have all been built and placed (sdp->rgrps is only updated
> after the resource group has been placed).
>
> If I have missed out on another location to find the total number of
> resource groups to be built beforehand I am more than happy to move away
> from the rgrp address here.
The information is available once lgfs2_rgrps_plan() has been called but
until now it has been hidden away. I've just sent a patch to fix that by
returning the planned rgrp count from that function instead of a rgrp
size (which mkfs.gfs2 currently throws away).
Cheers,
Andy
prev parent reply other threads:[~2015-10-12 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 18:08 [Cluster-devel] [PATCH] mkfs.gfs2: Add a progress indicator to mkfs.gfs2 Paul Evans
2015-09-25 8:38 ` Andrew Price
2015-10-11 13:37 ` Paul Evans
2015-10-12 15:37 ` Andrew Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561BD3CB.8070209@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).