From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Mon, 12 Oct 2015 16:37:47 +0100 Subject: [Cluster-devel] [PATCH] mkfs.gfs2: Add a progress indicator to mkfs.gfs2 In-Reply-To: <561A65FD.9000609@redhat.com> References: <1443118097-16101-1-git-send-email-pevans@redhat.com> <560507F4.1080303@redhat.com> <561A65FD.9000609@redhat.com> Message-ID: <561BD3CB.8070209@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 11/10/15 14:37, Paul Evans wrote: > On 25/09/15 09:38, Andrew Price wrote: >> Would a running rgrp count/total be a more natural progress indicator >> than the rgrp address I wonder? > > I would agree that a running rgrp count/total would be a more natural > progress but I did not see a way to check the total number of resource > groups that were needed. It appears that the total is only known after > all the rgrps have all been built and placed (sdp->rgrps is only updated > after the resource group has been placed). > > If I have missed out on another location to find the total number of > resource groups to be built beforehand I am more than happy to move away > from the rgrp address here. The information is available once lgfs2_rgrps_plan() has been called but until now it has been hidden away. I've just sent a patch to fix that by returning the planned rgrp count from that function instead of a rgrp size (which mkfs.gfs2 currently throws away). Cheers, Andy