* [Cluster-devel] [GFS2 PATCH v2] GFS2: Protect freeing directory hash table with i_lock spin_lock
[not found] <1744548592.67923378.1446147842477.JavaMail.zimbra@redhat.com>
@ 2015-10-29 19:47 ` Bob Peterson
2015-10-30 14:25 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Bob Peterson @ 2015-10-29 19:47 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
This is a re-spin of a patch I posted earlier today.
Andy Price pointed out that my comment was wrong: The race concerns
gfs2_evict_inode, not gfs2_clear_inode (as the previous version's
comment indicated). Function gfs2_clear_inode exists in RHEL6 and
earlier, but not in upstream.
Revised patch description:
This patch changes function gfs2_dir_hash_inval so it uses the
i_lock spin_lock to protect the in-core hash table, i_hash_cache.
This will prevent double-frees due to a race between gfs2_evict_inode
and inode invalidation.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
index 487527b..ad8a5b7 100644
--- a/fs/gfs2/dir.c
+++ b/fs/gfs2/dir.c
@@ -388,8 +388,13 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip)
*/
void gfs2_dir_hash_inval(struct gfs2_inode *ip)
{
- __be64 *hc = ip->i_hash_cache;
+ __be64 *hc;
+
+ spin_lock(&ip->i_inode.i_lock);
+ hc = ip->i_hash_cache;
ip->i_hash_cache = NULL;
+ spin_unlock(&ip->i_inode.i_lock);
+
kvfree(hc);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Cluster-devel] [GFS2 PATCH v2] GFS2: Protect freeing directory hash table with i_lock spin_lock
2015-10-29 19:47 ` [Cluster-devel] [GFS2 PATCH v2] GFS2: Protect freeing directory hash table with i_lock spin_lock Bob Peterson
@ 2015-10-30 14:25 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2015-10-30 14:25 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
On 29/10/15 19:47, Bob Peterson wrote:
> Hi,
>
> This is a re-spin of a patch I posted earlier today.
> Andy Price pointed out that my comment was wrong: The race concerns
> gfs2_evict_inode, not gfs2_clear_inode (as the previous version's
> comment indicated). Function gfs2_clear_inode exists in RHEL6 and
> earlier, but not in upstream.
>
> Revised patch description:
>
> This patch changes function gfs2_dir_hash_inval so it uses the
> i_lock spin_lock to protect the in-core hash table, i_hash_cache.
> This will prevent double-frees due to a race between gfs2_evict_inode
> and inode invalidation.
>
> Signed-off-by: Bob Peterson <rpeterso@redhat.com>
> ---
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index 487527b..ad8a5b7 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -388,8 +388,13 @@ static __be64 *gfs2_dir_get_hash_table(struct gfs2_inode *ip)
> */
> void gfs2_dir_hash_inval(struct gfs2_inode *ip)
> {
> - __be64 *hc = ip->i_hash_cache;
> + __be64 *hc;
> +
> + spin_lock(&ip->i_inode.i_lock);
> + hc = ip->i_hash_cache;
> ip->i_hash_cache = NULL;
> + spin_unlock(&ip->i_inode.i_lock);
> +
> kvfree(hc);
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-30 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1744548592.67923378.1446147842477.JavaMail.zimbra@redhat.com>
2015-10-29 19:47 ` [Cluster-devel] [GFS2 PATCH v2] GFS2: Protect freeing directory hash table with i_lock spin_lock Bob Peterson
2015-10-30 14:25 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).