From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Date: Tue, 2 Feb 2016 11:56:23 +0000 Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Check if iopen is held when deleting inode In-Reply-To: <261186611.36036826.1450463926249.JavaMail.zimbra@redhat.com> References: <261186611.36036826.1450463926249.JavaMail.zimbra@redhat.com> Message-ID: <56B09967.4040409@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, Acked-by: Steven Whitehouse Steve. On 18/12/15 18:38, Bob Peterson wrote: > Hi, > > This patch fixes an error condition in which an inode is partially > created in gfs2_create_inode() but then some error is discovered, > which causes it to fail and call iput() before the iopen glock is > created or held. In that case, gfs2_delete_inode would try to > unlock an iopen glock that doesn't yet exist. Therefore, we test > its holder (which must exist) for the HIF_HOLDER bit before trying > to dq it. > > Signed-off-by: Bob Peterson > > diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c > index 8f960a5..d354e72 100644 > --- a/fs/gfs2/super.c > +++ b/fs/gfs2/super.c > @@ -1551,12 +1551,15 @@ static void gfs2_evict_inode(struct inode *inode) > goto out_truncate; > } > > - ip->i_iopen_gh.gh_flags |= GL_NOCACHE; > - gfs2_glock_dq_wait(&ip->i_iopen_gh); > - gfs2_holder_reinit(LM_ST_EXCLUSIVE, LM_FLAG_TRY_1CB | GL_NOCACHE, &ip->i_iopen_gh); > - error = gfs2_glock_nq(&ip->i_iopen_gh); > - if (error) > - goto out_truncate; > + if (test_bit(HIF_HOLDER, &ip->i_iopen_gh.gh_iflags)) { > + ip->i_iopen_gh.gh_flags |= GL_NOCACHE; > + gfs2_glock_dq_wait(&ip->i_iopen_gh); > + gfs2_holder_reinit(LM_ST_EXCLUSIVE, LM_FLAG_TRY_1CB | GL_NOCACHE, > + &ip->i_iopen_gh); > + error = gfs2_glock_nq(&ip->i_iopen_gh); > + if (error) > + goto out_truncate; > + } > > /* Case 1 starts here */ > >