From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo A. R. Silva Date: Tue, 20 Apr 2021 15:29:03 -0500 Subject: [Cluster-devel] [PATCH 006/141] gfs2: Fix fall-through warnings for Clang In-Reply-To: <84d07c8510abf95c9e656454961c09b14485b856.1605896059.git.gustavoars@kernel.org> References: <84d07c8510abf95c9e656454961c09b14485b856.1605896059.git.gustavoars@kernel.org> Message-ID: <5adf738a-315b-a80e-46ff-06822441a789@embeddedor.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 11/20/20 12:25, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple goto statements instead of just > letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva > --- > fs/gfs2/inode.c | 2 ++ > fs/gfs2/recovery.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c > index 077ccb1b3ccc..9a85214c2505 100644 > --- a/fs/gfs2/inode.c > +++ b/fs/gfs2/inode.c > @@ -960,6 +960,7 @@ static int gfs2_link(struct dentry *old_dentry, struct inode *dir, > break; > case 0: > error = -EEXIST; > + goto out_gunlock; > default: > goto out_gunlock; > } > @@ -1500,6 +1501,7 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry, > break; > case 0: > error = -EEXIST; > + goto out_gunlock; > default: > goto out_gunlock; > } > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index c26c68ebd29d..5b2a01d9c463 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -437,6 +437,7 @@ void gfs2_recover_func(struct work_struct *work) > case GLR_TRYFAILED: > fs_info(sdp, "jid=%u: Busy\n", jd->jd_jid); > error = 0; > + goto fail; > > default: > goto fail; >