From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Date: Fri, 20 Aug 2021 12:06:38 -0400 Subject: [Cluster-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks In-Reply-To: <0f4f3e65-1d2d-e512-2a6f-d7d63effc479@redhat.com> References: <20210820135707.171001-1-jlayton@kernel.org> <20210820135707.171001-2-jlayton@kernel.org> <0f4f3e65-1d2d-e512-2a6f-d7d63effc479@redhat.com> Message-ID: <5c533ef663b9447206754c46afcab65d107dd207.camel@kernel.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, 2021-08-20 at 17:52 +0200, David Hildenbrand wrote: > On 20.08.21 15:57, Jeff Layton wrote: > > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros > > have disabled it. Warn the stragglers that still use "-o mand" that > > we'll be dropping support for that mount option. > > > > Cc: stable at vger.kernel.org > > Signed-off-by: Jeff Layton > > --- > > fs/namespace.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/fs/namespace.c b/fs/namespace.c > > index ab4174a3c802..ffab0bb1e649 100644 > > --- a/fs/namespace.c > > +++ b/fs/namespace.c > > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void) > > } > > > > #ifdef CONFIG_MANDATORY_FILE_LOCKING > > +static bool warned_mand; > > static inline bool may_mandlock(void) > > { > > + if (!warned_mand) { > > + warned_mand = true; > > + pr_warn("======================================================\n"); > > + pr_warn("WARNING: the mand mount option is being deprecated and\n"); > > + pr_warn(" will be removed in v5.15!\n"); > > + pr_warn("======================================================\n"); > > + } > > Is there a reason not to use pr_warn_once() ? > > No reason at all. I'll send out a v3 set in a bit with that change. Thanks! -- Jeff Layton