From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Date: Mon, 21 Jan 2019 01:43:21 -0800 Subject: [Cluster-devel] [PATCH V14 00/18] block: support multi-page bvec In-Reply-To: <20190121081805.32727-1-ming.lei@redhat.com> References: <20190121081805.32727-1-ming.lei@redhat.com> Message-ID: <61dfaa1e-e7bf-75f1-410b-ed32f97d0782@grimberg.me> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > V14: > - drop patch(patch 4 in V13) for renaming bvec helpers, as suggested by Jens > - use mp_bvec_* as multi-page bvec helper name > - fix one build issue, which is caused by missing one converion of > bio_for_each_segment_all in fs/gfs2 > - fix one 32bit ARCH specific issue caused by segment boundary mask > overflow Hey Ming, So is nvme-tcp also affected here? The only point where I see nvme-tcp can be affected is when initializing a bvec iter using bio_segments() as everywhere else we use iters which should transparently work.. I see that loop was converted, does it mean that nvme-tcp needs to call something like? -- bio_for_each_mp_bvec(bv, bio, iter) nr_bvecs++; --