cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH 1/2][TRY #2] GFS2: Move glock superblock pointer to field gl_name
Date: Wed, 26 Aug 2015 10:12:20 -0400 (EDT)	[thread overview]
Message-ID: <653028784.17322751.1440598340513.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAHc6FU6NKPU3QuM0qbGJ1wtVoOs+OXq7J4izcui5xu86kav6sg@mail.gmail.com>

----- Original Message -----
> Bob,
> 
> how hard would it be to move the rhashtable into struct gfs2_sbd instead?
> 
> Thanks,
> Andreas

Hi Andreas,

I've suggested moving the glock hash table into the superblock a couple times
in the past, when it was still a normal hash table, but I've always been shot
down. The advantage was improved scalability and not having to filter out
the glocks you don't want from the ones you don't when you go to do things
like dumping glocks. There's one central point for all glocks everywhere.
With rhashtable, scalability isn't much of an issue anymore. The disadvantage
is having multiple hash tables to manage when you are trying to clear things
out when you're unloading the module, for example. I've always felt the
advantages outweighed the disadvantages, but others did not agree.

Regards,

Bob Peterson
Red Hat File Systems



  parent reply	other threads:[~2015-08-26 14:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 18:25 [Cluster-devel] [GFS2 PATCH 0/2] Increase GFS2 glock scalability Bob Peterson
2015-07-09 18:25 ` [Cluster-devel] [GFS2 PATCH 1/2] GFS2: Move glock superblock pointer to field gl_name Bob Peterson
2015-07-13 11:19   ` Steven Whitehouse
2015-07-13 13:39     ` [Cluster-devel] [GFS2 PATCH 1/2][TRY #2] " Bob Peterson
2015-07-13 19:19       ` Steven Whitehouse
2015-08-22 22:00         ` Andreas Gruenbacher
2015-08-23 10:53           ` Steven Whitehouse
2015-08-26 14:12           ` Bob Peterson [this message]
2015-07-09 18:25 ` [Cluster-devel] [GFS2 PATCH 2/2] GFS2: Use resizable hash table for glocks Bob Peterson
2015-07-13 11:19   ` Steven Whitehouse
2015-08-24 13:16   ` Andreas Gruenbacher
2015-08-24 13:31   ` Andreas Gruenbacher
2015-08-24 13:46   ` Andreas Gruenbacher
2015-08-27 13:34     ` Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=653028784.17322751.1440598340513.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).