cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] GFS2: Pull request (merge window)
Date: Mon, 4 Sep 2017 13:05:13 -0400 (EDT)	[thread overview]
Message-ID: <692652244.6959825.1504544713974.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1332965725.6958432.1504544624096.JavaMail.zimbra@redhat.com>

Hi Linus,

Sorry this is a bit rushed, but I wanted to get this out this week, and
I'll be traveling for the next ten days with unknown Internet access.

Please consider pulling the following changes for the GFS2 file system.

Regards,

Bob Peterson
----------------------------------------------------------------
The following changes since commit da029c11e6b12f321f36dac8771e833b65cec962:

  exec: Limit arg stack to at most 75% of _STK_LIM (2017-07-07 20:05:08 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-4.14.fixes

for you to fetch changes up to 309e8cda596f6552a32dd14b969ce9b17f837f2f:

  gfs2: preserve i_mode if __gfs2_set_acl() fails (2017-08-31 07:53:15 -0500)

----------------------------------------------------------------
We've got a whopping 29 GFS2 patches for this merge window, mainly
because we held some back from the previous merge window until we
could get them perfected and well tested. We have a couple patch
sets, including my patch set for protecting glock gl_object and
Andreas Gruenbacher's patch set to fix the long-standing shrink-
slab hang, plus a bunch of assorted bugs and cleanups:

1. I fixed a bug whereby an IO error would lead to a double-brelse.
2. Andreas Gruenbacher made a minor cleanup to call his relatively
   new function, gfs2_holder_initialized, rather than doing it
   manually. This was just missed by a previous patch set.
3. Jan Kara fixed a bug whereby the SGID was being cleared when
   inheriting ACLs.
4. Andreas found a bug and fixed it in his previous patch,
   "Get rid of flush_delayed_work in gfs2_evict_inode". A call to
   flush_delayed_work was deleted from *gfs2_inode_lookup and added
   to gfs2_create_inode.
5. Wang Xibo found and fixed a list_add call in inode_go_lock
   that specified the parameters in the wrong order.
6. Coly Li submitted a patch to add the REQ_PRIO to some of GFS2's
   metadata reads that were accidentally missing them.
7 - 10. I submitted a 4-patch set to protect the glock gl_object
   field. GFS2 was setting and checking gl_object with no locking
   mechanism, so the value was occasionally stomped on, which caused
   file system corruption.
11. I submitted a small cleanup to function gfs2_clear_rgrpd.
   It was needlessly adding rgrp glocks to the lru list, then pulling
   them back off immediately. The rgrp glocks don't use the lru list
   anyway, so doing so was just a waste of time.
12. I submitted a patch that checks the GLOF_LRU flag on a glock
   before trying to remove it from the lru_list. This avoids a lot
   of unnecessary spin_lock contention.
13. I submitted a patch to delete GFS2's debugfs files only after
   we evict all the glocks. Before this patch, GFS2 would delete the
   debugfs files, and if unmount hung waiting for a glock, there was
   no way to debug the problem. Now, if a hang occurs during umount,
   we can examine the debugfs files to figure out why it's hung.
14. Andreas Gruenbacher submitted a patch to fix some trivial typos.
15 - 19. Andreas also submitted a five-part patch set to fix the
   longstanding hang involving the slab shrinker: dlm requires
   memory, calls the inode shrinker, which calls gfs2's evict, which
   calls back into DLM before it can evict an inode.
20. Abhi Das submitted a patch to forcibly flush the active items
   list to relieve memory pressure. This fixes a long-standing bug
   whereby GFS2 was getting hung permanently in balance_dirty_pages.
21. Thomas Tai submitted a patch to fix a slab corruption problem
   due to a residual pointer left in the lock_dlm lockstruct.
22. I submitted a patch to withdraw the file system if IO errors
   are encountered while writing to the journals or statfs system
   file which were previously not being sent back up. Before, some
   IO errors were sometimes not be detected for several hours, and
   at recovery time, the journal errors made journal replay
   impossible.
23. Andreas has a patch to fix an annoying format-truncation compiler
   warning so GFS2 compiles cleanly.
24. I have a patch that fixes a handful of sparse compiler warnings.
25. Andreas fixed up an useless gl_object warning caused by an
   earlier patch.
26. Arvind Yadav added a patch to properly constify our rhashtable
   params declare.
27. I added a patch to fix a regression caused by the non-recursive
   delete and truncate patch that caused file system blocks to not
   be properly freed.
28. Ernesto A. Fern?ndez added a patch to fix a place where GFS2
   would send back the wrong return code setting extended attributes.
29. Ernesto also added a patch to fix a case in which GFS2 was
   improperly setting an inode's i_mode, potentially granting access
   to the wrong users.

----------------------------------------------------------------
Abhi Das (1):
      gfs2: forcibly flush ail to relieve memory pressure

Andreas Gruenbacher (10):
      gfs2: Lock holder cleanup (fixup)
      gfs2: Fixup to "Get rid of flush_delayed_work in gfs2_evict_inode"
      gfs2: Fix trivial typos
      gfs2: gfs2_glock_get: Wait on freeing glocks
      gfs2: Get rid of gfs2_set_nlink
      gfs2: gfs2_evict_inode: Put glocks asynchronously
      gfs2: Defer deleting inodes under memory pressure
      gfs2: Clean up waiting on glocks
      gfs2: Silence gcc format-truncation warning
      GFS2: Fix gl_object warnings

Arvind Yadav (1):
      gfs2: constify rhashtable_params

Bob Peterson (11):
      GFS2: Prevent double brelse in gfs2_meta_indirect_buffer
      GFS2: Introduce helper for clearing gl_object
      GFS2: Set gl_object in inode lookup only after block type check
      GFS2: Clear gl_object if gfs2_create_inode fails
      GFS2: Clear gl_object when deleting an inode in gfs2_delete_inode
      GFS2: Don't bother trying to add rgrps to the lru list
      GFS2: Don't waste time locking lru_lock for non-lru glocks
      GFS2: Delete debugfs files only after we evict the glocks
      GFS2: Withdraw for IO errors writing to the journal or statfs
      GFS2: Fix up some sparse warnings
      GFS2: Fix non-recursive truncate bug

Coly Li (1):
      gfs2: add flag REQ_PRIO for metadata I/O

Ernesto A. Fern?ndez (2):
      gfs2: don't return ENODATA in __gfs2_xattr_set unless replacing
      gfs2: preserve i_mode if __gfs2_set_acl() fails

Jan Kara (1):
      gfs2: Don't clear SGID when inheriting ACLs

Thomas Tai (1):
      gfs2: fix slab corruption during mounting and umounting gfs file system

Wang Xibo (1):
      GFS2: fix code parameter error in inode_go_lock

 fs/gfs2/acl.c        |  30 ++++++-----
 fs/gfs2/aops.c       |  14 +++++-
 fs/gfs2/bmap.c       |  24 +++++++--
 fs/gfs2/dir.c        |   4 +-
 fs/gfs2/file.c       |   3 +-
 fs/gfs2/glock.c      | 137 +++++++++++++++++++++++++++++++++++++++++----------
 fs/gfs2/glock.h      |  36 ++++++++++++++
 fs/gfs2/glops.c      |  30 +----------
 fs/gfs2/incore.h     |   4 +-
 fs/gfs2/inode.c      |  17 ++++---
 fs/gfs2/lock_dlm.c   |   5 +-
 fs/gfs2/log.c        |  13 +++++
 fs/gfs2/lops.c       |   7 ++-
 fs/gfs2/meta_io.c    |   9 ++--
 fs/gfs2/ops_fstype.c |   7 ++-
 fs/gfs2/quota.c      |   7 ++-
 fs/gfs2/rgrp.c       |   3 +-
 fs/gfs2/super.c      |  71 +++++++++++++++++++++++---
 fs/gfs2/util.h       |   1 +
 fs/gfs2/xattr.c      |   9 +++-
 20 files changed, 321 insertions(+), 110 deletions(-)



       reply	other threads:[~2017-09-04 17:05 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1332965725.6958432.1504544624096.JavaMail.zimbra@redhat.com>
2017-09-04 17:05 ` Bob Peterson [this message]
     [not found] <2063498114.10752149.1552067836491.JavaMail.zimbra@redhat.com>
2019-03-08 17:58 ` [Cluster-devel] GFS2: Pull request (merge window) Bob Peterson
     [not found] <180051537.56890898.1545229879645.JavaMail.zimbra@redhat.com>
2018-12-19 14:31 ` Bob Peterson
     [not found] <1929897739.23623737.1540322729596.JavaMail.zimbra@redhat.com>
2018-10-23 19:26 ` Bob Peterson
2018-10-24 16:35   ` Linus Torvalds
2018-10-24 16:41     ` Bob Peterson
     [not found] <1772901878.39899227.1528134744434.JavaMail.zimbra@redhat.com>
2018-06-04 17:53 ` Bob Peterson
     [not found] <242799785.15741010.1522776740239.JavaMail.zimbra@redhat.com>
2018-04-03 17:32 ` Bob Peterson
     [not found] <2035999397.5567269.1517410350526.JavaMail.zimbra@redhat.com>
2018-01-31 14:54 ` Bob Peterson
     [not found] <800692691.31850756.1510678641181.JavaMail.zimbra@redhat.com>
2017-11-14 16:57 ` Bob Peterson
2017-11-14 17:17   ` Bob Peterson
     [not found] <2018468119.28735933.1499259957760.JavaMail.zimbra@redhat.com>
2017-07-05 13:08 ` Bob Peterson
     [not found] <909713995.4565875.1494016018520.JavaMail.zimbra@redhat.com>
2017-05-05 20:28 ` Bob Peterson
2017-05-05 21:07   ` Linus Torvalds
     [not found] <1526627784.3659456.1493822813354.JavaMail.zimbra@redhat.com>
2017-05-03 16:41 ` Bob Peterson
     [not found] <468087826.25173671.1487684421990.JavaMail.zimbra@redhat.com>
2017-02-21 13:41 ` Bob Peterson
     [not found] <1872743029.687446.1475513532790.JavaMail.zimbra@redhat.com>
2016-10-03 16:52 ` Bob Peterson
     [not found] <404724578.17300814.1469208769730.JavaMail.zimbra@redhat.com>
2016-07-22 17:33 ` Bob Peterson
     [not found] <2074855986.8621406.1463772170266.JavaMail.zimbra@redhat.com>
2016-05-20 19:23 ` Bob Peterson
     [not found] <2094757318.39162844.1458219077321.JavaMail.zimbra@redhat.com>
2016-03-17 12:51 ` Bob Peterson
     [not found] <1243871936.8427302.1452623511952.JavaMail.zimbra@redhat.com>
2016-01-12 18:34 ` Bob Peterson
     [not found] <337313427.7367463.1447086799887.JavaMail.zimbra@redhat.com>
2015-11-09 16:45 ` Bob Peterson
     [not found] <987432592.26261269.1441889826020.JavaMail.zimbra@redhat.com>
2015-09-10 13:19 ` Bob Peterson
     [not found] <1946368926.25134466.1435330524247.JavaMail.zimbra@redhat.com>
2015-06-26 14:56 ` Bob Peterson
     [not found] <1305736412.15685734.1429033600005.JavaMail.zimbra@redhat.com>
2015-04-14 17:47 ` Bob Peterson
2015-04-14 23:16   ` Linus Torvalds
2015-04-15  7:34     ` Steven Whitehouse
2015-04-14 23:19   ` Linus Torvalds
2015-04-15 12:09     ` Bob Peterson
2015-02-10 11:04 Steven Whitehouse
  -- strict thread matches above, loose matches on Subject: below --
2014-12-08 18:26 Steven Whitehouse
2014-10-08 19:25 Steven Whitehouse
2014-06-04  9:33 Steven Whitehouse
2014-04-01 23:15 Steven Whitehouse
2014-04-04 21:52 ` Linus Torvalds
2014-04-07  9:31   ` Steven Whitehouse
2014-01-20 19:15 Steven Whitehouse
2013-11-05 15:39 Steven Whitehouse
2013-09-09  9:22 Steven Whitehouse
2013-07-01 15:20 Steven Whitehouse
2013-04-29 11:08 Steven Whitehouse
2013-02-19 16:38 Steven Whitehouse
2012-12-11 10:39 Steven Whitehouse
2012-09-13 13:42 [Cluster-devel] GFS2: Pull request (fixes) Steven Whitehouse
2012-10-01  9:09 ` [Cluster-devel] GFS2: Pull request (merge window) Steven Whitehouse
2012-07-23 14:59 Steven Whitehouse
2012-08-03  1:22 ` Linus Torvalds
2012-08-03 10:18   ` Steven Whitehouse
2012-08-03 16:16     ` Linus Torvalds
2012-05-21  8:17 Steven Whitehouse
2012-03-20 16:10 Steven Whitehouse
2012-01-06 12:09 Steven Whitehouse
2011-10-25  8:41 Steven Whitehouse
2011-07-22 12:08 Steven Whitehouse
2011-05-20  8:14 Steven Whitehouse
2011-03-16 13:55 Steven Whitehouse
2011-01-05 10:22 Steven Whitehouse
2010-10-21  9:43 Steven Whitehouse
2010-08-03  9:06 Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=692652244.6959825.1504544713974.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).