From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rix Date: Sun, 22 Nov 2020 08:33:16 -0800 Subject: [Cluster-devel] [RFC] MAINTAINERS tag for cleanup robot In-Reply-To: <2105f0c05e9eae8bee8e17dcc5314474b3c0bc73.camel@perches.com> References: <20201121165058.1644182-1-trix@redhat.com> <2105f0c05e9eae8bee8e17dcc5314474b3c0bc73.camel@perches.com> Message-ID: <6e8c1926-4209-8f10-d0f9-72c875a85a88@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 11/21/20 9:10 AM, Joe Perches wrote: > On Sat, 2020-11-21 at 08:50 -0800, trix at redhat.com wrote: >> A difficult part of automating commits is composing the subsystem >> preamble in the commit log. For the ongoing effort of a fixer producing >> one or two fixes a release the use of 'treewide:' does not seem appropriate. >> >> It would be better if the normal prefix was used. Unfortunately normal is >> not consistent across the tree. >> >> So I am looking for comments for adding a new tag to the MAINTAINERS file >> >> D: Commit subsystem prefix >> >> ex/ for FPGA DFL DRIVERS >> >> D: fpga: dfl: > I'm all for it. Good luck with the effort. It's not completely trivial. > > From a decade ago: > > https://lore.kernel.org/lkml/1289919077.28741.50.camel at Joe-Laptop/ > > (and that thread started with extra semicolon patches too) Reading the history, how about this. get_mataintainer.pl outputs a single prefix, if multiple files have the same prefix it works, if they don't its an error. Another script 'commit_one_file.sh' does the call to get_mainainter.pl to get the prefix and be called by run-clang-tools.py to get the fixer specific message. Defer minimizing the commits by combining similar subsystems till later. In a steady state case, this should be uncommon. > >> Continuing with cleaning up clang's -Wextra-semi-stmt >> diff --git a/Makefile b/Makefile > [] >> @@ -1567,20 +1567,21 @@ help: >> ? echo '' >> ? @echo 'Static analysers:' >> ? @echo ' checkstack - Generate a list of stack hogs' >> ? @echo ' versioncheck - Sanity check on version.h usage' >> ? @echo ' includecheck - Check for duplicate included header files' >> ? @echo ' export_report - List the usages of all exported symbols' >> ? @echo ' headerdep - Detect inclusion cycles in headers' >> ? @echo ' coccicheck - Check with Coccinelle' >> ? @echo ' clang-analyzer - Check with clang static analyzer' >> ? @echo ' clang-tidy - Check with clang-tidy' >> + @echo ' clang-tidy-fix - Check and fix with clang-tidy' > A pity the ordering of the code below isn't the same as the above. Taken care thanks! Tom