From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Thu, 31 May 2018 08:26:46 -0400 (EDT) Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Fix allocation error bug with recursive rgrp glocking In-Reply-To: <20180531110823.29096-1-agruenba@redhat.com> References: <492648779.38585592.1527707671394.JavaMail.zimbra@redhat.com> <20180531110823.29096-1-agruenba@redhat.com> Message-ID: <711845674.38892813.1527769606813.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- > Bob, > > On 30 May 2018 at 21:14, Bob Peterson wrote: > > Before this patch function gfs2_write_begin, upon discovering an > > error, called gfs2_trim_blocks while the rgrp glock was still held. > > That's because gfs2_inplace_release is not called until later. > > agreed. > > > This patch reorganizes the logic a bit so gfs2_inplace_release > > is called to release the lock prior to the call to gfs2_trim_blocks, > > thus preventing the glock recursion. > > gfs2_trim_blocks only needs to be called after __block_write_begin but > with your proposed patch, it also ends up being called on other error > paths. This complicates gfs2_write_begin, so how about the below patch > instead? > > Thanks, > Andreas Hi Andreas, My previous version looked a lot like yours, so yes, I'll take your version instead. It's going to be overwritten by your iomap-write patch set eventually anyway. Regards, Bob Peterson