* [Cluster-devel] [GFS2 PATCH] GFS2: fix regression in dir_double_exhash [not found] <1178155712.65865136.1371213053825.JavaMail.root@redhat.com> @ 2013-06-14 12:39 ` Bob Peterson 2013-06-14 12:55 ` Steven Whitehouse 0 siblings, 1 reply; 2+ messages in thread From: Bob Peterson @ 2013-06-14 12:39 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, Recent commit e8830d8 introduced a bug in function dir_double_exhash; it was failing to set h in the fall-back case. This patch corrects it. Regards, Bob Peterson Red Hat File Systems Signed-off-by: Bob Peterson <rpeterso@redhat.com> --- fs/gfs2/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index f0c7052..147fcc5 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -1125,13 +1125,14 @@ static int dir_double_exhash(struct gfs2_inode *dip) if (IS_ERR(hc)) return PTR_ERR(hc); - h = hc2 = kmalloc(hsize_bytes * 2, GFP_NOFS | __GFP_NOWARN); + hc2 = kmalloc(hsize_bytes * 2, GFP_NOFS | __GFP_NOWARN); if (hc2 == NULL) hc2 = __vmalloc(hsize_bytes * 2, GFP_NOFS, PAGE_KERNEL); if (!hc2) return -ENOMEM; + h = hc2; error = gfs2_meta_inode_buffer(dip, &dibh); if (error) goto out_kfree; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cluster-devel] [GFS2 PATCH] GFS2: fix regression in dir_double_exhash 2013-06-14 12:39 ` [Cluster-devel] [GFS2 PATCH] GFS2: fix regression in dir_double_exhash Bob Peterson @ 2013-06-14 12:55 ` Steven Whitehouse 0 siblings, 0 replies; 2+ messages in thread From: Steven Whitehouse @ 2013-06-14 12:55 UTC (permalink / raw) To: cluster-devel.redhat.com Hi, Looks good. I'll push this to the -nmw tree shortly, Steve. On Fri, 2013-06-14 at 08:39 -0400, Bob Peterson wrote: > Hi, > > Recent commit e8830d8 introduced a bug in function dir_double_exhash; > it was failing to set h in the fall-back case. This patch corrects it. > > Regards, > > Bob Peterson > Red Hat File Systems > > Signed-off-by: Bob Peterson <rpeterso@redhat.com> > --- > fs/gfs2/dir.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c > index f0c7052..147fcc5 100644 > --- a/fs/gfs2/dir.c > +++ b/fs/gfs2/dir.c > @@ -1125,13 +1125,14 @@ static int dir_double_exhash(struct gfs2_inode *dip) > if (IS_ERR(hc)) > return PTR_ERR(hc); > > - h = hc2 = kmalloc(hsize_bytes * 2, GFP_NOFS | __GFP_NOWARN); > + hc2 = kmalloc(hsize_bytes * 2, GFP_NOFS | __GFP_NOWARN); > if (hc2 == NULL) > hc2 = __vmalloc(hsize_bytes * 2, GFP_NOFS, PAGE_KERNEL); > > if (!hc2) > return -ENOMEM; > > + h = hc2; > error = gfs2_meta_inode_buffer(dip, &dibh); > if (error) > goto out_kfree; > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-14 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1178155712.65865136.1371213053825.JavaMail.root@redhat.com>
2013-06-14 12:39 ` [Cluster-devel] [GFS2 PATCH] GFS2: fix regression in dir_double_exhash Bob Peterson
2013-06-14 12:55 ` Steven Whitehouse
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).